Tickets :: Comment on [#4807] iCalendar/vfreebusy.php does not correctly handle merging

* Your Email Address
* Spam protection	Enter the letters below: .__..__ . .. ,.__. \| \|[__)\ / \./ [__] \|__\|[__) \/ \| \| \|
Comment	> When merging two vfreebusy objects ("merge" function in > vfreebusy.php) the start and end points are handled incorrectly. > > > > 1) If the start date on the periods to be merged differs it may > happen that the start attribute ("DTSTART") gets set twice. The > reason for that is that the "setAttribute" call is lacking the > $append = false option. > > > > 2) When two periods are merged the HIGHER start date gets selected as > the new start point while the LOWER end date gets selected as the new > end point. This seems wrong, but maybe I am overlooking something. > The code fragment has been checked in about two years ago > (http://cvs.horde.org/diff.php?r1=1.12&r2=1.13&f=framework%2FiCalendar%2FiCalendar%2Fvfreebusy.php) and it would seem odd that this error has been overlooked. So maybe I am > wrong. > > > > Anyhow, the attached patch would fix these two problems and adds a > corresponding test to the vfreebusy.phpt file.
Attachment
Watch this ticket