Tickets :: Comment on [#4797] A large horde_vfs table can cause large memory usage during GC

* Your Email Address
* Spam protection	Enter the letters below: __ __ __ .__..__. / `/ `/ `[__]\| \| \__.\__.\__.\| \|\|__\|
Comment	>> I was able to get it to work, with two small changes. > >> > >> 1) Make the first line of the function be '$conn = $this->_connect();' > >> 2) Change '$this->_write_db' to be '$this->db' > > > > This means you are not using HEAD, and in fact you're not even using > the latest FW_3 code. VFS_sql was changed a while ago to not load the > body of every file in the _listFolder() method (it uses the db server > to get the file sizes instead), which is probably what's driving up > your memory usage anyway. I'll keep the changes, but you should > really update. > > > >> A couple other comments, I notice a lot of the other functions use > >> $this->_db->quote(), but this one doesn't. > > > > It uses a prepared statement (the ? placeholders). > > > >> Also, will there be a similar function put in place for sql_file? > > > > That'd have to do filesystem operations anyway - not nearly as much > of a speed/efficiency increase. I'd probably accept a patch for one > though.
Attachment
Watch this ticket