Tickets :: Comment on [#4794] Wrong eventduration with imported calendars

* Your Email Address
* Spam protection	Enter the letters below: .__ . ..___.__.. [__)\ /[__ [__]\| [__) \/ [___\| \|\|___
Comment	> ianh (at) hardersoft (dot) com writes: > > > >> [...] Importing Canadian Calendars made all full day events span two > >> days. The calculated end date was increased by one day. > >> > >> Also, when viewing events remotely (through webdav interface) in > >> Lightening, the end dates were shown one day too soon. [...] > > > > It seems to be wrong to add a day to the end of an all-day event in > > kronolith/lib/Driver.php. Also, I think that it is wrong to subtract a > > day from the end date when exporting an all-day event. I've attached a > > patch that changes Driver.php accordingly. > > > > There seems to be another bug in Driver.php. One of the comments says > > that DTEND matches YYYYMMDDT2359(59\|00), i.e. the second may be 59 or > > 00. But the code doesn't check whether the _minute_ is 59; instead > > the code checks whether the _second_ is 59. This bug gets also fixed > > by our patch. > >
Attachment
Watch this ticket