6.0.0-beta6
▾
Tasks
New Task
Search
Photos
Wiki
▾
Tickets
New Ticket
Search
dev.horde.org
Toggle Alerts Log
Help
4/10/26
H
istory
A
ttachments
C
omment
W
atch
Download
Comment on [#4299] Don't dim signatures in quoted text
*
Your Email Address
*
Spam protection
Enter the letters below:
.__ .___.\ /. ..__ [__) | >< \ /[__) | | / \ \/ [__)
Comment
> Your issue is bogus. The algorithim for dimming signatures recently > changed from dimming everything below the first signature line to > dimming everything below the last signature line. It has nothing to > do with quoted vs. unquoted. The new algorithim makes more sense > because it won't result in an entire message being dimmed if the > signature appears on top. Not to start a holy war, but it is > definitely preferred etiquette to quote under previous text, so the > user's signature should *always* appear at the bottom of the message. > > > > However, your message does bring up another issue - namely, we > shouldn't be dimming signatures in quoted text anyway if just for the > simple fact we start mixing closed/unclosed div/span tags and the > page won't render properly. i.e., in this case, pseudocode looks > like this: > > > > <div class="quoted1"> > > <div class="quoted2"> > > HTML > > <span class="signature"> > > Signature > > </div> > > </div> > > </span> > > > > This is a severe limitation with the current Text_Filter scheme since > each filter doesn't (and can't) know if a previous filter has > inserted div/span tags that may intersect the current text. Yuck. > > > > Possible solution - we have to do signature dimming in the highlight > quote filter. This would ensure we weren't setting a signature span > across quoted div's.
Attachment
Watch this ticket
N
ew Ticket
M
y Tickets
S
earch
Q
uery Builder
R
eports
Saved Queries
Open Bugs
Bugs waiting for Feedback
Open Bugs in Releases
Open Enhancements
Enhancements waiting for Feedback
Bugs with Patches
Enhancements with Patches
Release Showstoppers
Stalled Tickets
New Tickets
Horde 5 Showstoppers