Tickets :: Comment on [#4062] Kolab.php compatibility with php5

* Your Email Address
* Spam protection	Enter the letters below: ._.. ..___. __. __ \| \ / \| (__ / ` _\|_ \/ \| .__)\__.
Comment	>> It took a while but now I converted Kolab.php to use the Horde_DOM > >> package. This is the first half of the patch which needs to be > >> applied to framework/DOM/DOM.php. > > > > Great! > > > >> It adds a number of additional functions from > >> http://alexandre.alapetite.net/doc-alex/domxml-php4-php5/domxml-php4-to-php5.php.txt that are needed >> by > >> Kolab.php. > > > > Please document that including author, license, conditions etc. in > the file header. > > > >> I hope I matched the style of the horde sources. > > > > Yes, with one exception: if-clauses must always use curly braces.
Attachment
Watch this ticket