Tickets :: Comment on [#3731] Currencies and Taxes

* Your Email Address
* Spam protection	Enter the letters below: . ,.__ . ..__ .__. \./ [__)\|_/ [ __[__] \| \| \| \[_./\| \|
Comment	>>> I still dont understand RDO::update call good. > >> Can you say what about it doesn't make sense? > > > > I found it. The RDO_Mapper::update has the optional second parameter > "fields". But is when instance of RDO is passed as an object this is > ignored. I guess we should check if it is null. > > > > @ -212,9 +212,7 @@ > > if ($object instanceof RDO) { > > $key = $this->describe()->key; > > $id = $object->$key; > > - if (is_null($fields)) { > > - $fields = $object->getFields(); > > - } > > + $fields = $object->getFields(); > > } else { > > $id = $object; > > }
Attachment
Watch this ticket