6.0.0-beta6
▾
Tasks
New Task
Search
Photos
Wiki
▾
Tickets
New Ticket
Search
dev.horde.org
Toggle Alerts Log
Help
4/10/26
H
istory
A
ttachments
C
omment
W
atch
Download
Comment on [#3474] block login for a given time span after x failed logins
*
Your Email Address
*
Spam protection
Enter the letters below:
__ .___.__ __.. . / `[__ [ __(__ | | \__.[___[_./.__)|__|
Comment
> Hi, > > > > here is the third revision ;) > > > >> A few more comments: > >> - The patch to conf.xml is missing > > fixed > > > >> - You assign $history_data, but never use it > > fixed > > > >> - You loop through $history_log->getData() but overwrite > >> $history_list each time inside the loop > > using array_shift now > > > >> - You could use getByTimestamp() to get the number of failed logins > >> during the configured time span in one go > > To complicated, left the code as it is > > > >> - You never delete the history entries (when you have successful > >> logins), which will fill up the history table with every failed login > > Only the relevant timestamps are copied into $new_login_history, so > > the history will always be around 5 entries, not more. > > > > Ciao, > > Tobias > >
Attachment
Watch this ticket
N
ew Ticket
M
y Tickets
S
earch
Q
uery Builder
R
eports
Saved Queries
Open Bugs
Bugs waiting for Feedback
Open Bugs in Releases
Open Enhancements
Enhancements waiting for Feedback
Bugs with Patches
Enhancements with Patches
Release Showstoppers
Stalled Tickets
New Tickets
Horde 5 Showstoppers