Tickets :: Comment on [#2834] patch for qmail-ldap

* Your Email Address
* Spam protection	Enter the letters below: .__ . ..___.. .. . [__)\|_/ \| \|\ \|\|__\| [__)\| \ \| \| \\|\| \|
Comment	>>>> * LDAP attribute for marking active vacation message can be array - > >>>> more entries - eg: 'reply', 'nolocal'. The value of the 'active' > >>>> attribute is then specified as: reply\|nolocal > >>> > >>> What is the unset() call for? > >> it's because ldap_get_attributes adds to returned array the number of > >> attributes in the entry (see: > >> http://www.php.net/manual/en/function.ldap-get-attributes.php). We > >> don't want to have the value of "count" in the result (eg.: > >> 2\|reply\|nolocal) > > > > Committed. > > > >>>> * the vacation message format is modified for qmail-ldap (for now > >>>> hardcoded in 2 places) > >>>> Example: > >>>> "%HEADER%\nSubject: " . _("On vacation message (Autoreply to: > >>>> %SUBJECT%)") . "\n\n" . _("I'm on vacation and will not be reading my > >>>> mail for a while.") . "\n" . _("Your mail will be dealt with when I > >>>> return.") . "\n"; > >>> > >>> This breaks any other driver, or am I missing something? Where is > >>> %HEADER% being replaced? > >> > >> 1. see http://www.qmail-ldap.org/wiki/LDAP_REPLYTEXT > >> 2. this patch will break only other LDAP using mailsystems > >> (hardcoding is done only in Driver/ldap.php). Solution TODO: > > > > No, it breaks all drivers because it changes $vacationtxt which is > passed to all drivers, but only qmail LDAP understands it. > > > >> a) specify mailsystem type in the configuration (exim, qmail-ldap) > >> b) use callback for encoding/decoding vacation message > > > > b) as long as it still works as it did before, for standard setups.
Attachment
Watch this ticket

Saved Queries