Tickets :: Comment on [#2799] IMP_Fetchmail

* Your Email Address
* Spam protection	Enter the letters below: .__ . ,. ..___. . [__) \./ \| \| \| \| \| \ \| \|__\| \| \__\|
Comment	> IMP_Fetchmail_imap supplies defaults for {l,r}mailbox in its constructor: > > > > function IMP_Fetchmail_imap($params) > > { > > /* Default values for a couple of parameters. */ > > $defaults = array( > > 'rmailbox' => 'INBOX', > > 'lmailbox' => 'INBOX' > > ); > > $params = array_merge($defaults, $params); > > > > but these values never apply because imp/fetchmailprefs.php > unconditionally sets all parameters: > > > > foreach ($fetchmail->getParameterList() as $val) { > > $fm_account->setValue($val, Util::getFormData('fm_' . $val), > $to_edit); > > } > > > > so they wind up being empty strings (""). > > > > Should IMP_Fetchmail_imap() override empty strings with the defaults? > Does having an empty value for {l,r}mailbox make any sense (IOW, do > any remote servers interpret this as a sane default)? > >
Attachment
Watch this ticket