Tickets :: Comment on [#2265] Add better shared resource support to menus

* Your Email Address
* Spam protection	Enter the letters below: . ,.___.__ .___.. . \./ [__ [ __ \| \|\/\| \| \| [_./ \| \| \|
Comment	>> Done and done, though I'm still not that sure that it's perfect. > > > > Getting better. :) > > > > 1. Please rename the functions to > getTasklistWidget()/getCalendarWidget(). Personal taste, but a bit > clearer about what the function is. > > > > 2. For xhtml, you should use disabled="disabled", not disabled="true". > > > > 3. Please spell out boolean and integer in phpdoc comments. > > > > 4. You need to echo the result of the function in the templates you > use it in; you just call it, which results in nothing being output. > > > > 5. Please don't combine patches to different applications in one file > unless you do the diff from the Horde directory. Try using cvs diff > -uRn. > > > > 6. Don't use double-quoted strings unless necessary for variable > interpolation or newlines, etc. > > > > 7. In several places in Nag, the old code would pre-select the > default tasklist (possibly in Kronolith as well). Your function > doesn't provide an option for that; it should be added back in. > > > > > > Not trying to be picky for no reason, but since you've been improving > it, I thought I'd give you as much feedback as I could. :)
Attachment
Watch this ticket