Tickets :: Comment on [#2121] national characters absolutely bad with cyrus sieve

* Your Email Address
* Spam protection	Enter the letters below: . .. .. .. .. . \| \|\|\ \|\|\ \|\| \|\ / \|/\\|\| \\|\| \\|\|/\\| \/
Comment	>> Isn't that a problem, that Horde/String.php never require_once'd in > > > > No it isn't, I know now :) > > > > Anyway, now I read your coding_standards document (better lately, > than never) and I found, that I should use include_once, so I fix > this in this patch. > > > > A bigger fix is utf8'ized comments, since it is very annoying if you > can't pipe the generated output to a 'recode UTF-8..ISO-8859-2' as a > system administrator because of ISO-8859-2 comments (which are > invalid UTF-8 characters). > > > > Anyway, I think, that it is not a good idea to have localized > comments in a generated config file. System administrators know > english well enough and if someone is doing some shell magic based on > english comments it can be a bg surprise that he has got non-english > users with localized chinese autocommented sieve data... :) > > > > So _() should be removed from around comment strings which will go to > sieve scripts, I think. > > > > Thanks, > > Gergely
Attachment
Watch this ticket