Tickets :: Comment on [#1683] Patch to generate static user FB URL

* Your Email Address
* Spam protection	Enter the letters below: .__ .__ . .. .\ / [ __[ __\| \|\| \| >< [_./[_./\|__\|\|/\\|/ \
Comment	> There's a cache namespace collision possible with my patch. The FB > info is cached with the username or calendar as the key (depending on > if u or c is specified). If I have a share named kevin_myer@iu13.org > and I call fb.php with c=kevin_myer@iu13.org, the cache will contain > FB info for a share. If I shortly thereafter call fb.php with > u=kevin_myer@iu13.org, and I have defined a different set of shares > that should be used to generate my FB info (i.e. fb_cals is set to > one or more shares), I'll get the cached results of just > c=kevin_myer@iu13.org. > > > > In other words, if fb_cals=kevin_myer@iu13.org and I call fb.php with > either u, or c, I'll get the right results because u == c. > > > > If fb_cals=kevin_myer@iu13,org, and another share > (examplesharepadto32bits...), I'll get the wrong results from the > cache, because u is actually c + exampleshare, but it will be cached > with my email address as the key (and what results will be returned > will depend on whether fb.php was called with u or c first). > > > > Or maybe in plainer terms - my patch uses the same key for both user > FB and single calendar FB info. A simple solution would be to > prepend a "u-" or a "c-" before the share/user name, so the cached > result for u-kevin_myer@iu13.org would be my fb_cals FB info and the > cached result for c-kevin_myer@iu13.org would be a share FB info.
Attachment
Watch this ticket

Saved Queries