Tickets :: Comment on [#1291] Folder dropdown sorted incorrectly

* Your Email Address
* Spam protection	Enter the letters below: ._. __..___.. .. . \| (__ _/ \| \|\|_/ _\|_.__)./__.\|__\|\| \
Comment	> I agree with 2 (although, not sure if RFC says that INBOX is always > uppercase, if it is the case, than string comparation should be case > sensitive for both this check and the previously existing check for > INBOX folder itself at the beggining of fucntion). > > > > As for 1 (speed improvement), it is dependent on IMAP server used, > and the way user organized his folders. On Cyrus with > alternate_namespace turned off, I clearly see the benefit and > performance improvement. On everything else, hm, it's doubtfull. If > alternate_namespace is turned on, and user has a flat folder > structure (for example, only top-level folders: INBOX, Folder1, > Folder2, and so on), it will be actually slower. In that case you > only introduced one additional if($this->_sortinbox && ($i == 0)) > check, case that is already checked at the beggining of function. > > > > Anyhow, your patch worked for me. If you commit it, maybe replace > [$i] with [0]. $i is always zero in that part of code (because of > "if" statement). Or using full folder name instead of array > component (like in my patch, is there case insensitive version of > strpos?).
Attachment
Watch this ticket