Tickets :: Comment on [#12612] > This will break with $year is not a string type. ctype_int *requires* > the input value to be typed as a string and will return unexpected > results when it is passed an integer (as the phpdoc says this method

* Your Email Address
* Spam protection	Enter the letters below: __..__ .__ . ..__ (__ [__)[__)\|\/\|[__) .__)\| \\| \\| \|\|
Comment	>> This will break with $year is not a string type. ctype_int requires >> the input value to be typed as a string and will return unexpected >> results when it is passed an integer (as the phpdoc says this method >> takes). > > oh, thanks for catching this. The doc even says "may not return the > expected result.". > >> $year must be explicitly cast to string before being passed to >> ctype_int If indeed it is more efficient than to just use the simple >> regex. > > I measured the first part of the function with 10.000.000 invocations. > The speed gain is 0.1s -> Not worth the trouble. >
Attachment
Watch this ticket