Tickets :: Comment on [#12597] AS: Detect deletes on a non-CONDSTORE server

* Your Email Address
* Spam protection	Enter the letters below: . .. .. ..__.. . \|\ \|\ /\|\/\|\| \|\ / \| \\| \/ \| \|\|__\| \/
Comment	>> Committed, with a few tweaks and changes. >> >> Thanks! > > ehrm, those tweaks contain little bugs :o) > -> Not all setChanges() calls were updated during "cleanup", > it will still access $status['messages'] for CONDSTORE servers. > > Also we would need another if() for CONDSTORE/non-CONDSTORE > for the inital sync. > > The code is more complex than it needs to be: We can specify > Horde_Imap_Client::STATUS_HIGHESTMODSEQ > for non-CONDSTORE servers and the Imap_Client will return 0 for the > modseq in that case. > This would get rid of the duplicated $status_flags and the > $imap->queryCapability('CONDSTORE') call. > > Also querying the amount of messages is very cheap for a CONDSTORE server, > no need to over-optimize this and create more complex code paths. > -> Let's store the number of messages for all cases. > > For the ping() code, I moved the modseq code path first > so it will be the default for modern IMAP servers. > Though I doubt this makes any noticeable performance difference ;) > > Please consider the attached patch. Works fine on a non-CONDSTORE server. >
Attachment
Watch this ticket