Tickets :: Comment on [#1257] Incomplete Thread View

* Your Email Address
* Spam protection	Enter the letters below: .___. ..___.___.. . [__ \|\/\|[__ _/ \ / [___\| \|\| ./__. \/
Comment	> This patch makes no sense. First, why are you changing the return > value of getKey from false to null? That doesn't get you anywhere. > Second, why are you using ++$key instead of $key++? You are missing > a whole potential case by doing this. Third, if > ($this->_thread[$key]) doesn't exist, you have a mailbox that is > corrupt - that code should never be reached or else there are issues > elsewhere. So it makes a whole bunch of sense to exit the loop > rather than ignore the entry - which may lead to some very weird > output.
Attachment
Watch this ticket