Tickets :: Comment on [#12265] IMAP package throws errors

* Your Email Address
* Spam protection	Enter the letters below: .__ .__..__. __ .___. \| \[__]\| \|/ ` \| \|__/\| \|\|__\\__. \|
Comment	>> But additionally I'm >> still convinced that a good function should filter out garbage input >> to prevent crashes or loops as this one. > > You are confusing the scope of the function. > > In a public API, in which I (as a developer) do not have control over > the input, then yes - it makes sense (when possible) to check for bad > input. > > However, this is a private function. All input is controlled by the > developer. These functions SHOULD be very strict about data inputs > since, if an input is incorrect, that is a giant red flag that > something is probably wrong in the calling code. > > The _readLine() function is only called from functions that MUST have > an active IMAP connection. If that is not happening, then this error > must be fixed at the source. Fixing it there will actually fix the > problem rather than suppressing the error messages. > >> I'll need some days to dive into it, I'll call back once I know the >> reason forthe null resources. > > Shouldn't be that difficult. You just need to post the backtrace > part of the debug output. SInce $_stream should never be null in > that method, any trigger of the debug code has found an issue. (I'm > not asking for a patch of the broken code - I'm just asking for help > in finding where the broken code is).
Attachment
Watch this ticket