Tickets :: Comment on [#12160] Infinity loop on event with recurrence

* Your Email Address
* Spam protection	Enter the letters below: . ..___. .. .\ / \|_/ [__ \ /\| \| >< \| \\| \/ \|/\\|/ \
Comment	> After several hours of debugging I finally figured out what's going on: > The code to exclude recurring objects ending in the past was not > working correctly. > > Consider this scenario: > We call _listEvents($startDate = "2012-10-20", $endDate=null). We > have the following event: > > start: 2012-09-17 10:00 > end: 2012-09-17 12:00 > recurrence: type: daily, start: 2012-09-17, interval: 2 > > As there is no fixed recurrence end date, the current code failed > to examine the recurrence and passed that event on to Kronolith::addEvents(). > > Kronolith::addEvents() later on noticed it's a recurring event and > tried to calculate the start date of the event as "$startDate = > $event->nextRecurrence($startDate)". > It didn't expect that nextRecurrence() might return false and then > ran into an endless loop. > > Attached patch fixes the recurrence handling. > > With this patch applied, the endless loop is gone > (and my safety protection loggers don't detect anything). > > The SQL driver already works correctly. >
Attachment
Watch this ticket