Tickets :: Comment on [#11983] limit synced mailboxes by user preferences

* Your Email Address
* Spam protection	Enter the letters below: . . __..___.__ \| \|(__ [__ \| \ \|___\__\|.__)[___\|__/
Comment	>>>> Feel free to submit a patch and I'll review. >>> >>> So here's my attempt to a patch to >>> /usr/share/php5/PEAR/Horde/Core/ActiveSync/Driver.php >> >> 1) You need to review http://www.horde.org/apps/horde/docs/CODING_STANDARDS >> 2) _getMailFolder() still calls getSpecialMailboxes() and compares >> the names anyway. You should build the map of the special mailboxes >> regardless if it is $inbox_only or not, store it locally in the >> object and use it in getMailFolder() as well. > > I've tried to incorporate your comments - is this new patch > sufficient for approval? > > Concerning the array of special mailboxes - is my approach > (initializing the member to "null" in the c'tor and verifying against > that value for lazy loading in "_getMailFolders()") correct? > > Let me know if I should further improve this patch.
Attachment
Watch this ticket