Tickets :: Comment on [#11906] Theme cache 'appversion' support causes performance bug

* Your Email Address
* Spam protection	Enter the letters below: . __..__ . .\ / \|(__ [__)\|\ \| >< \__\|.__)[__)\| \\|/ \
Comment	> Hi, > > I've installed the xhprof PHP profiler and played around with it. > While looking at the output, I noticed that 28% of the total time > on an average click was spent on building the theme cache. > > -> Something had to be wrong > > I've added debug logging and identified the 'appversion' version > check mechanism > in Themes/Cache.php to be the problem. > > Take a look at the Horde_Themes_Cache::getCacheId() function in > Themes/Cache.php. It computes a cache version id consisting of the > version of the current app + the horde version. > > When the cache is written by > Horde_Core_Factory_ThemesCache::shutdown(), the Horde registry is > fully initialized. The cache version id of the theme will include a > proper app version. > > > When the theme cache is loaded the first time, the horde registry is > not fully initialized, so $registry->getVersion(appname) will return > a different value than during writeout. > ('unknown') > > -> The cache gets thrown away and rebuild. > This is a huge performance drain. > > Workaround: Don't use the "appversion" version check mechanism. >
Attachment
Watch this ticket