Tickets :: Comment on [#11449] CRAM-MD5 broken for imap

* Your Email Address
* Spam protection	Enter the letters below: .__ .___. .. __ [__)[__ \|_/ \| / ` \| \| \| \\|___\__.
Comment	> This corrects the param order for hmac and corrects the output type of hmac. > Tested CRAM-MD5 logins now work, and also manually verified > calculated results. > > From 2944c3dd0ffd2686d862d90a16f58124ec7c98d1 Mon Sep 17 00:00:00 2001 > From: Patrick Domack <patrickdk@patrickdk.com> > Date: Tue, 25 Sep 2012 14:16:17 -0400 > Subject: [PATCH] Fix CRAM-MD5 auth > > --- > .../Imap_Client/lib/Horde/Imap/Client/Socket.php \| 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/framework/Imap_Client/lib/Horde/Imap/Client/Socket.php > b/framework/Imap_Client/lib/Horde/Imap/Client/Socket.php > index d88ed7d..3febe49 100644 > --- a/framework/Imap_Client/lib/Horde/Imap/Client/Socket.php > +++ b/framework/Imap_Client/lib/Horde/Imap/Client/Socket.php > @@ -570,7 +570,7 @@ class Horde_Imap_Client_Socket extends > Horde_Imap_Client_Base > > > $cmd = new Horde_Imap_Client_Data_Format_List( > - base64_encode($this->_params['username'] . ' ' . > hash_hmac(strtolower(substr($method, 5)), > $this->getParam('password'), base64_decode($ob['line']), true)) > + base64_encode($this->_params['username'] . ' ' . > hash_hmac(strtolower(substr($method, 5)), base64_decode($ob['line']), > $this->getParam('password'), false)) > ); > $this->_sendLine($cmd, array( > 'debug' => '[' . $method . ' Response]' > -- > 1.7.9.5 > >
Attachment
Watch this ticket