Tickets :: Comment on [#11207] Favourites driver matches all email address searches

* Your Email Address
* Spam protection	Enter the letters below: .___.. ..___. ..__. _/ \| \|[__ \ /[__] ./__.\|/\\|\| \/ \| \|
Comment	>> There is nothing wrong with the preferences. And I have verified >> multiple times that nothing has changed in IMP 5 relating to the >> image viewing code. >> >> On my system, however, something appears broken with the Turba >> getField API call. It matches ALL entries in the favourites table, >> even if those emails do not match the search query (the matches are >> not even close). The query being run is this: >> >> Array >> ( >> [AND] => Array >> ( >> [0] => Array >> ( >> [field] => email >> [op] => = >> [test] => foo@example.com >> ) >> ) >> ) >> >> Two problems with this query: >> 1) The code in the Favourites driver does not handle the '=' op, only >> the LIKE op. >> 2) Any AND query that doesn't match will be considered as "found" and >> will be returned. (That's why the absence of the '=' op constititues >> matching). >> >> Thus any email address, if querying the favourites addressbook, will >> ALWAYS be considered matched AFAICT. No idea if this is your issue >> and, if so, why it suddenly started when upgrading only IMP. > > Aha, progress... > > Unselect "Automatically show images in messages when the sender is in > my address book?" and it works again. > > So you are spot-on, it is matching everything as being in the address book.
Attachment
Watch this ticket