Tickets :: Comment on [#10678] Alarm in Recurring Events is not working

* Your Email Address
* Spam protection	Enter the letters below: .___.___..___.__.. . [__ _/ [__ [__]\|\/\| \| ./__.[___\| \|\| \|
Comment	>> Hello again, >> >> your first commit (the older one) fixed the missing alarm notifications, >> >> but the horde alarm, alarm_start is not being set correctly, because >> is equal to event creation time - 5 minuts or something like that, > > I don't see this. I see alarm_start being set to the configured time > for the alarm. i.e., If I create an event for 13:00, and say to > remind me 15 minutes prior, it is saved as 12:45 (adjusted for GMT, > of course). > >> and the event start hour that is showed in the alarm popup >> notification is the event hour start - the event_alarm time, set in >> event. > > This I do see...the time displayed in the notification is the > alarm_start time, not the event_start time (so with a 15 minute prior > alarm setting, it shows the event start time 15 minutes early). > >> If i create one recurring event in the past with start hour - >> event_alarm time set after current hour, the notification is showed >> in the current session, but if the start hour - event_alarm time is >> later than current hour, the event alarm is not showed until >> logout/login. > > This I can't reproduce. I've tried all types of different times, > event lengths etc.. > > 0) Current time: 13:00, Tuesday > 1) Create a daily recurring event on Monday at 11:00, for 1 hour with > a 15 minute prior alarm. Correctly, no alarm is shown. > 2) Create a daily recurring event on Monday at 12:30, for 1 hour with > 15 minute prior alarm: Since the current time is within this event's > timespan, an alarm is shown immediately after saving. > 3) Create a daily recurring event on Monday at 14:00 with 15 minute > prior alarm. No alarm is shown until 13:45. > > Which of these cases is failing for you? The only thing broken that I > can see locally is the displayed start time of the event in the > notification... > >> The second commit (the recent) doesn't change anything, that i noticed. > > The last commit is needed to catch (2) above. If we are past the > current occurrence's start time, but not past it's end time, the code > that calculates the next occurrence will not count the current event, > so the event will potentially be missed when polling for alarms. >
Attachment
Watch this ticket

Saved Queries