Tickets :: Comment on [#10171] SQL-Problems during sync

* Your Email Address
* Spam protection	Enter the letters below: .___.. ..__ . .._. _/ \| \|[__)\| \| \| ./__.\|__\|\| \\|__\|_\|_
Comment	> I observe the same error (Horde 4.0.6, kronolith 3.0.4, postgresql > 8.4) when upgrading from kronolith-H3 with event-uid-entrys of all > numbers (mis-interpreted as integer). The reason seems to be a > missing quotation of $objectName (here the event_uid) in line 116 to > 118 in /var/www/horde/content/lib/Objects/Manager.php: > > foreach ($this->_db->selectAll('SELECT object_id, object_name FROM ' > . $this->_t('objects') > . ' WHERE object_name IN (' . implode(',', > array_map(array($this->_db, 'quote'), array_keys($objectName))) > . ') AND type_id = ' . $type) as $row) { > > If I leave out the mapping to array($this->_db, 'quote') and > hard-encode the quotes, it solves the problem for me: > > foreach ($this->_db->selectAll("SELECT object_id, object_name FROM " > . $this->_t('objects') > . " WHERE object_name IN ('" . implode("','", array_keys($objectName)) > . "') AND type_id = " . $type) as $row) { > > (see also appended patch). > > I have no idea if this does work with other DB-backends too, though, > as I don't really understand the use of the 'quote'-mapping in the > first place. > > Andreas >
Attachment
Watch this ticket