Tickets :: Comment on [#10091] ACLs courier-imap

* Your Email Address
* Spam protection	Enter the letters below: .__ . .___._.. . [ __\| [__ \| \|_/ [_./\|___\| _\|_\| \
Comment	>>>> first, courier-imap doesn't wnat anybody to play/mess with the >>>> "administrators" user. Is this specific to courier-imap ? If not, >>>> should there be a check for not modifying this user's ACLs ? >>> >>> This is specific to Courier, I guess. "administrators" is no more >>> special than any other users so there is no reason to lock access to >>> it. >> >> So I have no problem with errors being thrown by the IMAP server if >> their rights are attempted to be altered and they are not supposed to. > > Ideally, I would have like "administrators" ACL to be hidden from > users. but if this is specific to only one IMAP server then this is > probably too much work/hack. > And since users can't modify it anyway, I guess I'm ok with an error > being displayed. > >> But this patch should completely remove the other two "disabled" UI >> elements. Does this work better? > > No, but the following patch helps : > > --- > framework/Imap_Client/lib/Horde/Imap/Client/Base.php.org 2011-05-18 > 09:01:42.000000000 +0200 > +++ framework/Imap_Client/lib/Horde/Imap/Client/Base.php 2011-05-18 > 09:01:50.000000000 +0200 > @@ -2595,11 +2595,7 @@ > return array_merge($rights, str_split(reset($capability))); > } > > - // Add RFC 2086 rights (DEPRECATED) > - return array_merge($rights, array( > - Horde_Imap_Client::ACL_CREATE, > - Horde_Imap_Client::ACL_DELETE > - )); > + return $rights; > } > > I've seen traces of those two ACL const in > framework/Imap_Client/lib/Horde/Imap/Client/Data/AclCommon.php. > May be you want to remove them ? > > >
Attachment
Watch this ticket

Saved Queries