Tickets :: Comment on [#10017] applications are incorrectly "polled" even if they are not installed

* Your Email Address
* Spam protection	Enter the letters below: .__.. .. .. .. . [__]\|\/\|\|\/\|\|__\|\|_/ \| \|\| \|\| \|\| \|\| \
Comment	>> Correct me if I'm wrong but this code always marks 'heading' and >> 'sidebar' applications as active, no? >> >> } elseif ($app['status'] == 'heading' \|\| >> $app['status'] == 'sidebar') { >> continue; >> } > > Yes - that is correct. > > But again, this should not matter. Because in the sidebar generation > code, this happens: > > case 'sidebar': > try { > $registry->callAppMethod($params['app'], > 'sidebarCreate', array('args' => array($this->_tree, > empty($params['menu_parent']) ? null : $params['menu_parent'], > isset($params['sidebar_params']) ? $params['sidebar_params'] : > array()))); > } catch (Horde_Exception $e) { > if ($e->getCode() != Horde_Registry::NOT_ACTIVE) { > Horde::logMessage($e, 'ERR'); > } > } > > callAppMethod() should immediately fail because the application > ($params['app']) is not active. > > It is debatable whether we could optimize this check more. Right > now, the code is very clean, since all application existence checking > takes place inside of the Registry object. Conversely, Jan has shown > in the past that throwing/catching Exceptions is not the most > efficient of operations. So there is a trade-off between nice > OO-coding style with performance here. However, for purposes of > analyzing this current issue, this is irrelevant. > > Back to the analysis... when callAppMethod() throws an Exception, we > check to see if the exception is that the application does not exist. > If that is the error, then we ignore the exception and continuing > processing the next sidebar block. And this is what happens on my > installation. > > So once again, the question remains: why is this Exception returning > something other than Horde_Registry::NOT_ACTIVE for you? Because > this is what is broken, not anything dealing with marking 'sidebar' > registry blocks active or inactive.
Attachment
Watch this ticket

Saved Queries