Tickets :: Comment on [#11738] Revamped kolab-webmail bundle for H5

* Your Email Address
* Spam protection	Enter the letters below: . .. ..__ . . \| \|\|__\|[ __\ / \|___\__\|\| \|[_./ \/
Comment	>>> There's still a few of my questions unanswered/unresolved. >> >> Thanks for pointing this out - from my point of view I had already >> declared the basar closed ;) >> >>> - Why does >>> $GLOBALS['injector']->getInstance('Horde_Kolab_Session')->getImapServer() >>> not work? >> As I wrote, I couldn't tell. I just observed that it does work with >> an explicitly set server and doesn't via the injector statement. But >> upon re-reading this ticket, I noticed that now, due to some other >> change, a re-check is in order - yes, the injector statements >> currently work. > > Great. > >> BTW, what advantage is it in IMP to read the hostname via injector, >> but read the port number from the config? I suggest you or anyone >> more Horde-experienced than me to look this over and create a >> probably more consistent usage of the pre-configured IMAP server. > > AFAIU the IMAP server can be configured per user in Kolab's LDAP > backend, the port can't. > >> Do you need a modified patch? > > Yes, please. > >>> - Why did you remove the mbox_icon and display_folder hooks? >> Do you see this as unresolved? I have not received any response to my >> comments and was not able to resolve the issue myself. >> I just retested, when activating the mbox_icon hook the folder list >> on the left no longer loads in IMP, but despite DEBUG logging I >> couldn't spot obvious error messages. It's sufficient to have the >> code in hooks.php, even when not activated in imp/conf.d. > > You mentioned fatal errors earlier in the ticket, but I didn't see a > bug report or more detailed information about those anywhere. If they > don't work, they need fixing, not disabling. > >>> - Why are the $vars->ldap__* setters necessary? >> Do you see this as unresolved? I have not received any response to my >> comments and concluded from my tests that those values needed to be >> set to make it work. Thus I had set them. > > AFAIU the Kolab code doesn't use the $conf['ldap'] configuration, or > is it? If not, setting those here is not necessary. > Also, why do you change the default ports for IMAP and SMTP? > >> Please let me know what you see as open points where I can help. > > The 'kolab' address book is already defined in > turba/config/backends.php. You only need to enable it in > backends.d/20-kolab.php.
Attachment
Watch this ticket

Saved Queries