6.0.0-beta6
▾
Tasks
New Task
Search
Photos
Wiki
▾
Tickets
New Ticket
Search
dev.horde.org
Toggle Alerts Log
Help
4/9/26
H
istory
A
ttachments
C
omment
W
atch
Download
Comment on [#7301] fix bug: sftp operations in VFS/ssh2.php do not work due to escapeshellarg
*
Your Email Address
*
Spam protection
Enter the letters below:
.__ .__.. .. ..__. [ __| ||_/ | || | [_./|__|| \|/\||__\
Comment
> The filename argument for the ssh2_sftp_* functions should not be > escapeshellarg'ed, white spaces and other special characters are > already handled fine by these functions. This is opposed to the > ssh_scp_* functions that do require them. > > > > The escapeshellarg was introduced when trying to fix a problem where > the ssh_scp_* functions did not use escapeshellarg (bug #6756). Chuck > Hagenbuch must have guessed that the ssh2_sftp_* functions required > them too, but neither he nor the reporter of the bug seemed to have > actually tested any codepaths that uses the ssh2_sftp_* functions. > > > > Attached is a patch that reverts the code for the ssh_sftp_* > functions to the state before the 'fix'. > > > > I'm CC'ing the people involved in bug #6756 to get their statement.
Attachment
Watch this ticket
N
ew Ticket
M
y Tickets
S
earch
Q
uery Builder
R
eports
Saved Queries
Open Bugs
Bugs waiting for Feedback
Open Bugs in Releases
Open Enhancements
Enhancements waiting for Feedback
Bugs with Patches
Enhancements with Patches
Release Showstoppers
Stalled Tickets
New Tickets
Horde 5 Showstoppers