Tickets :: Comment on [#7272] Date_Holidays split up breaks translation support for non-christian drivers

* Your Email Address
* Spam protection	Enter the letters below: .__ ..___.___. [__) \|[__ [__ \| \| \__\|\| [___\|___
Comment	> From IRC discussion > > > > mrubinsk > > 12:17:14 date_holidays is kicking my butt > > mrubinsk > > 12:17:32 > > oh, it doesn't have a en_us file > > mrubinsk > > 12:17:40 > > well, that sucks > > mrubinsk > > 12:17:58 > > ...as does the new directory structure > > yunosh > > 12:19:14 > > yeah, ken is keeping implenting all kind of bc breaking changes > (which is fine), without actually implementing my requests that would > make it much easier dealing with those > > mrubinsk > > 12:23:10 > > ah well, I'm giving up on this for now. It's completely unusable for > me anyway, without any en_us files. > > mrubinsk > > 12:23:44 > > not to mention the files that are there are present in different > places...for de for instance, we have > > mrubinsk > > 12:24:05 > > data/Date_Holidays/lang/Christian/de_DE.* > > mrubinsk > > 12:24:07 > > and > > mrubinsk > > 12:24:25 > > data/Date_Holidays_Germany/lang/Christian/de_DE* > > mrubinsk > > 12:24:28 > > very confusing :) > > yunosh > > 12:26:06 > > uh, and that shouldn't happen :) > > yunosh > > 12:26:22 > > probably some left-overs from earlier versions > > yunosh > > 12:26:37 > > pear list-files is the definite reference > > mrubinsk > > 12:27:44 > > ...and both files are there in that list :) > > yunosh > > 12:28:06 > > heh > > mrubinsk > > 12:28:14 > > hence the confusion :) > > yunosh > > 12:28:34 > > actually, it should be data/Date_Holidays_Christian/lang/de_DE.* > > mrubinsk > > 12:29:45 > > ...but I thought that Christian was part of the base driver? > > yunosh > > 12:30:07 > > oh, is it? > > yunosh > > 12:30:12 > > i thought all have been separated out > > mrubinsk > > 12:30:19 > > there isn't a Date_Holiday_Christian package > > mrubinsk > > 12:30:23 > > Holidays > > yunosh > > 12:30:26 > > ah, k then > > yunosh > > 12:30:34 > > then the first path looks correct to me > > yunosh > > 12:30:53 > > unless there are extensions to the christian driver in the germany package > > yunosh > > 12:31:06 > > which is well possible, from a holiday standpoint > > yunosh > > 12:31:44 > > but that would make it completely impossible to correctly load translations > > mrubinsk > > 12:31:49 > > exactly > > yunosh > > 12:32:10 > > that sucks pretty much > > mrubinsk > > 12:32:21 > > yup > > mrubinsk > > 12:32:57 > > ...and a diff on the two de files shows no differences > > mrubinsk > > 12:33:10 > > which might be a good sign for us > > yunosh > > 12:33:13 > > well, if he doesn't get it implement it properly, we might want to > fork it, and use gettext for the translations > > mrubinsk > > 12:34:24 > > I'll dump the pertinent parts of this conversation onto the ticket
Attachment
Watch this ticket

Saved Queries