6.0.0-alpha10
▾
Tasks
New Task
Search
Photos
Wiki
▾
Tickets
New Ticket
Search
dev.horde.org
Toggle Alerts Log
Help
5/15/25
H
istory
A
ttachments
C
omment
W
atch
Download
Comment on [#14868] text_diff_renderer_inline calls itself, making subclassing impossible
*
Your Email Address
*
Spam protection
Enter the letters below:
.__..__.. ..__ ._. | || ||_/ [ __ | |__||__\| \[_./_|_
Comment
> If you want to use another _encode function in a subclass of > Horde_Text_Diff_Renderer_Inline you can subclass it. But on line ~160 > the class makes a new instantiation of itself, thereby nullifying the > original subclass. > > Small patch: > > @@ -158,7 +158,8 @@ > } > > /* Get the diff in inline format. */ > - $renderer = new Horde_Text_Diff_Renderer_inline > + $class = static::class; > + $renderer = new $class
Attachment
Watch this ticket
N
ew Ticket
M
y Tickets
S
earch
Q
uery Builder
R
eports
Saved Queries
Open Bugs
Bugs waiting for Feedback
Open Bugs in Releases
Open Enhancements
Enhancements waiting for Feedback
Bugs with Patches
Enhancements with Patches
Release Showstoppers
Stalled Tickets
New Tickets
Horde 5 Showstoppers