Tickets :: Comment on [#11785] RTL bugs in horde

* Your Email Address
* Spam protection	Enter the letters below: . ..__ . .. . __. \|\/\|[__)\|\/\|\| \|(__ \| \|\| \\| \|\|__\|.__)
Comment	>> When viewing horde in RTL mode (hebrew/arabic) the layout breaks >> terribly, I jave started identifying some problems but since I am not >> familiar with the framework I don't necisarrily know how to solve >> them. >> >> One problem is some inline stile that assumes LTR languages: >> # grep -R 'style="left:' /usr/share/horde4/ >> /usr/share/horde4/templates/sidebar/sidebar.html.php:<div >> id="horde-slideleft" class="horde-splitbar-vert" style="left:<?php >> echo $this->width ?>px"> >> /usr/share/horde4/kronolith/templates/dynamic/index.inc:<div >> id="horde-page" style="left:<?php echo >> $prefs->getValue('sidebar_width') ?>px"> > > Fixed, though this doesn't change the layout of course. There's much > more to do. > >> /usr/share/horde4/kronolith/templates/fbview/busyblock.html:<td><div >> class="kronolithFBBusy" style="left:<tag:left />;width:<tag:width >> />;"> </div></td> >> /usr/share/horde4/kronolith/templates/fbview/meetingblock.html:<td><div >> class="kronolithFBFree" style="left:<tag:left />;width:<tag:width >> />;"> </div></td> > > I left those out, because this also requires the fb table to be > rendered RTL. Or is it? > >> In the above examples a direction check should have been done and in >> the case of RTL they should have read: >> style="right:<?php echo $this->width ?>px" >> >> I realize some of these are part of the kronolith project and not >> horde at large, if you so prefer I will open a seperate bug for them. >> >> In screen.css there are also several parameters that should be >> direction dependent, I still need to sit down longer to identify them >> all but as a start: >> #horde-page has a padding that should be direction dependent. > > Fixed. RTL specific changes go to rtl.css. Please note that I already > updated it a bit, so make sure you work against a Git version of > Horde.
Attachment
Watch this ticket

Saved Queries