Tickets :: Comment on [#11680] Kolab Storage: serialize/unserialize handling

* Your Email Address
* Spam protection	Enter the letters below: .___._. __ .__ . [__ \| / `[ __ \| [____\|_\__.[_./\__\|
Comment	> Hi Gunnar, > > I'm not sure how the serialize/unserialize handling is done in Kolab_Storage. > Let's take Storage/Cache/Data.php as an example. > > The code in store() looks like this: > --------------------------------------------------- > $this->_data[self::STAMP] = serialize($stamp); > --------------------------------------------------- > > The _load() code does nothing special to the "self::STAMP" field. > > The getStamp() code looks like this: > ---------------------------------------------- > public function getStamp() > { > $this->_checkInit(self::STAMP); > return $this->_data[self::STAMP]; > } > ---------------------------------------------- > > Is there some recursive unserialize magic happening I don't see yet? > > IMHO if you call getStamp(), it will return garbage. > The same code pattern applies to a few other spots. > > OTOH the actual user of "Storage/Cache/Data.php" is > "Storage/Data/Cached.php". > That one unserializes the stamp before using it. > > Is this a performance optimization to move unserialize() to the calling side? > > Thomas >
Attachment
Watch this ticket