Tickets :: Comment on [#14868] text_diff_renderer_inline calls itself, making subclassing impossible

Search Results: 42 of 171 [ <<First <Prev Next> Last>> ] [ Return to Search Results ]

* Your Email Address
* Spam protection	Enter the letters below: .___..__ .__ . ..___ \| [ __[ __\| \|[__ \| [_./[_./\|/\\|\|
Comment	> If you want to use another _encode function in a subclass of > Horde_Text_Diff_Renderer_Inline you can subclass it. But on line ~160 > the class makes a new instantiation of itself, thereby nullifying the > original subclass. > > Small patch: > > @@ -158,7 +158,8 @@ > } > > /* Get the diff in inline format. */ > - $renderer = new Horde_Text_Diff_Renderer_inline > + $class = static::class; > + $renderer = new $class
Attachment
Watch this ticket