Tickets :: [#4324] Change _group_hook_groupName() to _group_hook($groupName)

6.0.0-beta1

7/5/25

Summary	Change _group_hook_groupName() to _group_hook($groupName)
Queue	Horde Framework Packages
Queue Version	HEAD
Type	Enhancement
State	Resolved
Priority	2. Medium
Owners	Horde Developers (at)
Requester	dorm (at) dorm (dot) org
Created	08/23/2006 (6891 days ago)
Due
Updated	12/20/2006 (6772 days ago)
Assigned	08/29/2006 (6885 days ago)
Resolved	11/22/2006 (6800 days ago)
Milestone
Patch	Yes

12/20/2006 11:42:59 PM	dorm (at) dorm (dot) org	Comment #11	Reply to this comment
I don't regularly run a HEAD installation, so I haven't actually tested it. But I spent some time looking over the code, and it looks good. Thanks.

11/22/2006 04:29:28 AM	Chuck Hagenbuch	Comment #10 State ⇒ Resolved	Reply to this comment
This is committed now - thanks! However the patch to Group/hooks.php didn't apply cleanly so I did some merging - please do test it and make sure that everything is working as expected.

09/22/2006 09:11:22 PM	dorm (at) dorm (dot) org	Comment #9 New Attachment: UPGRADING.1.17.patch	Reply to this comment
Attaching patch to docs/UPGRADING with information about this change. I added an "Upgrading Horde to 3.2" section at the top, since this change doesn't apply for v3.1.2. This may need to be changed depending on when these patches are included in a release.

08/29/2006 09:57:39 AM	Jan Schneider	Priority ⇒ 2. Medium

08/29/2006 09:56:58 AM	Jan Schneider	Assigned to Horde Developers State ⇒ Assigned

08/29/2006 09:56:33 AM	Jan Schneider	Deleted Original Message

08/29/2006 09:56:21 AM	Jan Schneider	Deleted Original Message

08/28/2006 10:41:27 PM		New Attachment: lib_Horde_Group_hooks.php.1.9.patch

08/28/2006 10:40:58 PM	dorm (at) dorm (dot) org	Comment #8 New Attachment: config_hooks.php.dist.1.99.patch	Reply to this comment
Ack, OK, sorry for the mix-up. I didn't realize it sorted by date, not by revision number. Anyway, patches for HEAD versions are attached.

08/28/2006 09:38:44 PM	Chuck Hagenbuch	Comment #7	Reply to this comment
No. That just means that FW_3 was changed more recently than HEAD, not that the branch is the most recent version. Revision 1.99 is the most up to date, HEAD version of the file.

08/28/2006 09:07:06 PM	dorm (at) dorm (dot) org	Comment #6	Reply to this comment
I mean that the latest version of hooks.php in CVS (1.7.2.10) is tagged with FRAMEWORK_3. So version 1.7.2.10 is both the FRAMEWORK_3 version, as well as what you get by checking out CVS HEAD.

08/27/2006 04:33:51 PM	Chuck Hagenbuch	Comment #5	Reply to this comment
Yeah, they should work for HEAD. I am never quite sure what to select when the latest version in CVS is tagged with FRAMEWORK_3. Eh? That doesn't make sense.

08/25/2006 04:28:20 PM	dorm (at) dorm (dot) org	Comment #4	Reply to this comment
Yeah, they should work for HEAD. I am never quite sure what to select when the latest version in CVS is tagged with FRAMEWORK_3.

08/24/2006 07:32:24 AM	Jan Schneider	Comment #3 State ⇒ Feedback Version ⇒ HEAD	Reply to this comment
This change will go to CVS HEAD only, so please make sure that your patches apply there correctly too, or provide updated patches. Thanks.

08/23/2006 02:40:37 PM	dorm (at) dorm (dot) org	Comment #2 New Attachment: hooks.php.dist.1.73.6.14.diff	Reply to this comment
Patch for config/hooks.php.dist attached.

08/23/2006 02:16:18 PM	dorm (at) dorm (dot) org	Comment #1 Priority ⇒ 1. Low State ⇒ New New Attachment: hooks.php.1.7.2.10.diff Queue ⇒ Horde Framework Packages Summary ⇒ Change _group_hook_groupName() to _group_hook($groupName) Type ⇒ Enhancement	Reply to this comment
Patch to lib/Horde/Group/hooks.php to use a _group_hook($groupName) hook function instead of _group_hook_groupName(). config/hooks.php will also need to be updated with an appropriate example group hook function. And docs/UPGRADING.