Summary | Cleanup default address book mess |
Queue | Turba |
Queue Version | Git master |
Type | Enhancement |
State | Accepted |
Priority | 1. Low |
Owners | Horde Developers (at) |
Requester | jan (at) horde (dot) org |
Created | 11/28/2012 (4550 days ago) |
Due | |
Updated | 01/27/2016 (3395 days ago) |
Assigned | |
Resolved | |
Milestone | |
Patch | No |
State ⇒ Accepted
Priority ⇒ 1. Low
Priority ⇒ 2. Medium
Patch ⇒ No
Milestone ⇒
Assigned to
Queue ⇒ Turba
Summary ⇒ Cleanup default address book mess
Type ⇒ Bug
State ⇒ Feedback
book, some using each other, and used differently and different places.
1) default_dir preference
Only used in 2) and when importing contacts.
2) Turba_Api::getDefaultShare()
Only works on shares, looks for the 'default' share parameter (only
set by Kolab), but falls back to default_dir pref, which could be any,
even non-share address book. Only place used is the hook example for
IMP's 'add_source' preference.
3) Turba::getDefaultAddressbook()
Simply picks the first share or the first of all address books,
complete ignoring user preferences and is used in some API methods, as
the default synchronization source, and to determine the initial
address book after logging in.
It might make sense to have different defaults for general address
book usage and for adding contacts, though:
- The default_dir pref mentions both adding and importing contacts,
while it's only used for importing contacts.
- We don't do this in any other application. Granted, all other
applications can display more than one source, so this makes Turba
different.
Another problem: after (my) removal of the address book sorting and
selection, there is no way anymore for the user to define the default
address book (by moving it to the top of the list).
So my short-term suggestion is to use default_dir for all default
address book selections, defaulting to whatever the backend provides
as the default (Kolab), and falling back to the first of all available
address books, with a priority to the user's own shares.