Summary | Refactored LDAP Prefs driver using Horde_Ldap |
Queue | Horde Framework Packages |
Queue Version | Git master |
Type | Enhancement |
State | Resolved |
Priority | 2. Medium |
Owners | jan (at) horde (dot) org |
Requester | heinz (at) htl-steyr (dot) ac (dot) at |
Created | 11/13/2012 (4566 days ago) |
Due | |
Updated | 08/11/2016 (3199 days ago) |
Assigned | |
Resolved | 08/11/2016 (3199 days ago) |
Milestone | Horde_Core 2.25.1 |
Patch | Yes |
State ⇒ Resolved
Milestone ⇒ Horde_Core 2.25.1
commit a013889cd1451c234b1c55bde420c0f2b97c2670
Author: Jan Schneider <jan@horde.org>
Date: Thu Aug 11 12:03:36 2016 +0200
uid is no longer required (
Request #11697).Don't apply to FW_5_2 though, this is mostly cosmetic.
horde/config/conf.xml | 2 --
horde/package.xml | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
http://github.com/horde/horde/commit/a013889cd1451c234b1c55bde420c0f2b97c2670
commit d5ec2922df85674d6e4a018c558e5e9d340c784f
Author: Jan Schneider <jan@horde.org>
Date: Thu Aug 11 11:55:50 2016 +0200
[jan] Allow to specify user DN search parameters for LDAP with
all bind methods (
Request #11697, heinz@htl-steyr.ac.at).framework/Core/lib/Horde/Config.php | 57
+++++++++----------------
framework/Core/lib/Horde/Core/Factory/Prefs.php | 2 +-
framework/Core/package.xml | 4 +-
3 files changed, 24 insertions(+), 39 deletions(-)
http://github.com/horde/horde/commit/d5ec2922df85674d6e4a018c558e5e9d340c784f
but just noticed that the patch still applied. Probably a PEBKAC.
New Attachment: Horde_Config_git.patch
now attached patch against git version
but i can't see any difference. What's wrong with my patch?
New Attachment: Factory_Prefs.patch
New Attachment: conf_xml.patch
New Attachment: Horde_Config.patch
user's DN all over the place when using LDAP.
in all bind modes
user config parameter binddn/bindpw for searching user's DN is never
used -> removed
I added this parameters with _configLDAPUser because the funktion
_configLDAPUser / the tag configldapuser is used in conf.xml for groups
maybe this function / the tag could be removed later
$conf['ldap']['user']['filter_type'] could be set
in all 'bindas' modes (in the global ldap configuration).
DN all over the place when using LDAP.
See also ticket #12299.
$conf['ldap']['user']['filter_type'] is also unset.
I think it is important to use a filter for searching the user
(searchfilter- or objectclass based)
Should i add filter_type (and the corresponding 'filter' respectively
'objectclass' entry)
to the ldap preferencies configuration ( $conf[prefs][params] )?
Alternatively the $conf['ldap']['user']['uid'] and
$conf['ldap']['user']['filter_type'] could be set
in all 'bindas' modes (in the global ldap configuration).
key attribute in $params['user']['uid']. This is only used for (and
only set when using) binding with the current user's credentials. For
preferences there is $params['uid'] which must be used to find the
user DN for the preference. This also answers your TODO in the
constructor docs, why we need a separate 'uid' parameter.
Please update the current driver version from Git master to use a
custom findUserDN().
commit 7d3bcbbfa44498d5986754b56e72218e2f2c0454
Author: Jan Schneider <jan@horde.org>
Date: Wed Jan 30 15:36:50 2013 +0100
Small tweaks (
Request #11697).framework/Prefs/lib/Horde/Prefs/Storage/Ldap.php | 53 ++++++++++-----------
1 files changed, 25 insertions(+), 28 deletions(-)
http://git.horde.org/horde-git/-/commit/7d3bcbbfa44498d5986754b56e72218e2f2c0454
commit e1ac2c94b11be68cefa7964cb83594bd3ba71e35
Author: Jan Schneider <jan@horde.org>
Date: Wed Jan 30 15:18:03 2013 +0100
Those todos are looking fine actually (
Request #11697).framework/Prefs/lib/Horde/Prefs/Storage/Ldap.php | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/e1ac2c94b11be68cefa7964cb83594bd3ba71e35
commit 2b728b0984127742b8278b43ad28796cd755aabc
Author: Jan Schneider <jan@horde.org>
Date: Wed Jan 30 15:16:23 2013 +0100
[jan] Fix LDAP driver and use Horde_Ldap (Heinz Schweiger
<heinz@htl-steyr.ac.at>,
Request #11697).framework/Prefs/lib/Horde/Prefs/Storage/Ldap.php | 423
++++++++--------------
framework/Prefs/package.xml | 4 +-
2 files changed, 151 insertions(+), 276 deletions(-)
http://git.horde.org/horde-git/-/commit/2b728b0984127742b8278b43ad28796cd755aabc
New Attachment: Ldap.php
Heinz
State ⇒ Feedback
Priority ⇒ 2. Medium
State ⇒ New
Patch ⇒ Yes
Milestone ⇒
Summary ⇒ Refactored LDAP Prefs driver using Horde_Ldap
Type ⇒ Enhancement
Queue ⇒ Horde Framework Packages
Since I am a longtime user of the horde, I will support the
development of horde5.
At out site we use OPENLDAP-Dictinary to store users (also with theire
horde preferences in an ou=horde under the users DN).
I have tried to extend horde prefs storage backend to use Horde_Ldap.
I would be happy my code improves horde.
Heinz
PS:
Horde_Core_Factory_Prefs, function create: In the case of a
Horde_Prefs_Storage_Ldap driver
the params for a newly created driverobject are taken from the 'ldap'
configuration and not from the 'prefs' configuration.
So, only "Horde default" settings for ldap would work, "Custom
settings" for Preferences are ignored.