6.0.0-alpha12
6/12/25

[#6313] Addressbook list not shown
Summary Addressbook list not shown
Queue Kolab
Type Bug
State Resolved
Priority 1. Low
Owners wrobel (at) horde (dot) org
Requester thomas.jarosch (at) intra2net (dot) com
Created 02/24/2008 (6318 days ago)
Due
Updated 03/03/2008 (6310 days ago)
Assigned 02/24/2008 (6318 days ago)
Resolved 03/03/2008 (6310 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
03/03/2008 11:07:39 AM Gunnar Wrobel Comment #3
State ⇒ Resolved
Reply to this comment
I assume this was the bug you wanted me to close again, right? From 
the error description it sounds like this refers to the getId() 
problems I fixed in CVS recently. Please reopen if the problem persists.
02/24/2008 09:04:29 PM thomas (dot) jarosch (at) intra2net (dot) com Comment #2
New Attachment: turba-use-share-ID.patch Download
Reply to this comment
$addressbook["INBOX%2FKontakte"]:
$addressbook->getName() = "INBOX/Kontakte";
$addressbook->get('name') = "Kontakte";
Looks like the Kolab share handling in Turba, at least for me using 
PHP 5.2.5, is currently not working at all as Turba expects the key of 
the shares (=>$addressbooks) array to be the value of getName() 
instead of getId().



I wrote a small proof-of-concept patch to fix the issue, works like a 
charm now.

Would it make sense to use getId() for refering to the addressbook 
source? If yes, are the changes in the patchset to the History needed 
as well (I'm not familiar with Horde's History framework)?



Cheers,

Thomas


02/24/2008 08:47:48 PM Chuck Hagenbuch Assigned to Gunnar Wrobel
State ⇒ Assigned
 
02/24/2008 08:47:40 PM Chuck Hagenbuch Version ⇒
Queue ⇒ Kolab
 
02/24/2008 06:52:10 PM thomas (dot) jarosch (at) intra2net (dot) com Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Addressbook list not shown
Queue ⇒ Turba
New Attachment: turba-fix-addressbook-list.patch Download
State ⇒ Unconfirmed
Reply to this comment
Hello together,



I did a fresh CVS checkout to test the current state

of the Kolab driver again. I had trouble getting the

list of addressbooks in Turba. Here's why:



Turba gets a list of addressbooks via



"$addressbooks = Turba::listShares(true);".



After that the names get sorted:

foreach ($addressbooks as $addressbook) {

     $sorted_addressbooks[$addressbook->getName()] = $addressbook->get('name');

}

asort($sorted_addressbooks);



Using the Kolab share driver the data was lay out like this:



$addressbook["INBOX%2FKontakte"]:

$addressbook->getName() = "INBOX/Kontakte";

$addressbook->get('name') = "Kontakte";



Because of the HTML escaping in the key of the array, Turba was unable

to find the addressbooks again when it tried to display the list.

Attached patch uses the real key of $addressbooks.



Cheers,

Thomas


Saved Queries