Summary | Addressbook list not shown |
Queue | Kolab |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | wrobel (at) horde (dot) org |
Requester | thomas.jarosch (at) intra2net (dot) com |
Created | 02/24/2008 (6318 days ago) |
Due | |
Updated | 03/03/2008 (6310 days ago) |
Assigned | 02/24/2008 (6318 days ago) |
Resolved | 03/03/2008 (6310 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Resolved
the error description it sounds like this refers to the getId()
problems I fixed in CVS recently. Please reopen if the problem persists.
New Attachment: turba-use-share-ID.patch
$addressbook->getName() = "INBOX/Kontakte";
$addressbook->get('name') = "Kontakte";
PHP 5.2.5, is currently not working at all as Turba expects the key of
the shares (=>$addressbooks) array to be the value of getName()
instead of getId().
I wrote a small proof-of-concept patch to fix the issue, works like a
charm now.
Would it make sense to use getId() for refering to the addressbook
source? If yes, are the changes in the patchset to the History needed
as well (I'm not familiar with Horde's History framework)?
Cheers,
Thomas
State ⇒ Assigned
Queue ⇒ Kolab
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Addressbook list not shown
Queue ⇒ Turba
New Attachment: turba-fix-addressbook-list.patch
State ⇒ Unconfirmed
I did a fresh CVS checkout to test the current state
of the Kolab driver again. I had trouble getting the
list of addressbooks in Turba. Here's why:
Turba gets a list of addressbooks via
"$addressbooks = Turba::listShares(true);".
After that the names get sorted:
foreach ($addressbooks as $addressbook) {
$sorted_addressbooks[$addressbook->getName()] = $addressbook->get('name');
}
asort($sorted_addressbooks);
Using the Kolab share driver the data was lay out like this:
$addressbook["INBOX%2FKontakte"]:
$addressbook->getName() = "INBOX/Kontakte";
$addressbook->get('name') = "Kontakte";
Because of the HTML escaping in the key of the array, Turba was unable
to find the addressbooks again when it tried to display the list.
Attached patch uses the real key of $addressbooks.
Cheers,
Thomas