6.0.0-beta1
9/23/25

[#6211] Cache shares
Summary Cache shares
Queue Ansel
Type Enhancement
State Resolved
Priority 1. Low
Owners mrubinsk (at) horde (dot) org
Requester duck (at) obala (dot) net
Created 02/05/2008 (6440 days ago)
Due
Updated 02/07/2008 (6438 days ago)
Assigned
Resolved 02/07/2008 (6438 days ago)
Milestone
Patch No

History
02/07/2008 04:18:12 PM Michael Rubinsky Comment #6
State ⇒ Resolved
Reply to this comment
Tweaked a bit and committed, thanks.
02/07/2008 02:19:58 PM Michael Rubinsky Comment #5
State ⇒ Accepted
Reply to this comment
Yea, just me being overly cautious again :)



Convinced...
02/07/2008 08:20:41 AM Duck Comment #4 Reply to this comment
I like the idea in general, but I'm hesitant to allow the storage of
a potentially large number of shares in the global cache.  I know you
have a fairly large userbase, any ideas on memory/disk/whatever
consumption?
Is the administrator task to wonder about cache. No other modules 
wonder about it, I don't see a reason why doing it here.





If you need an periodical clean up for your file based cache you can 
add a cron job like this



for s in $( find  cachedir -mtime -1 ); do

     rm s

done



This will delete all files older then one day.
02/07/2008 03:29:19 AM Chuck Hagenbuch Comment #3
Assigned to Michael Rubinsky
Reply to this comment
I like the idea in general, but I'm hesitant to allow the storage of
a potentially large number of shares in the global cache.
Why? If there are concerns about the amount of data in a cache on a 
backend that doesn't already limit it (like memcache), users can run 
pruning scripts (or we can add limits if really necessary).
Plus, this should probably be a seperate config in addition to the
general cache config since it potentially stores large number of
shares.
I just don't see this as a concern. If we end up spending a lot of 
time caching data that's never used in the cache, that's one thing, 
but shares are pretty static and accessed often.
02/07/2008 12:47:15 AM Michael Rubinsky Comment #2
State ⇒ Feedback
Reply to this comment
I like the idea in general, but I'm hesitant to allow the storage of a 
potentially large number of shares in the global cache.  I know you 
have a fairly large userbase, any ideas on memory/disk/whatever 
consumption?



Plus, this should probably be a seperate config in addition to the 
general cache config since it potentially stores large number of shares.



Any one else with thoughts?
02/05/2008 11:26:03 AM Duck Comment #1
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Cache shares
Queue ⇒ Ansel
New Attachment: Ansel-cache.diff Download
State ⇒ New
Reply to this comment
We can control where a share changes, and they not change often. So 
cache them if "usecache" configuration option is enabled.

Saved Queries