Tickets :: [#6049] submit/back buttons disabled [->disableButton()] in acl.html template

6.0.0-beta1

9/20/25

Summary	submit/back buttons disabled [->disableButton()] in acl.html template
Queue	IMP
Queue Version	4.2-RC1
Type	Bug
State	Resolved
Priority	1. Low
Owners	selsky (at) columbia (dot) edu, slusarz (at) horde (dot) org
Requester	m.gabriel (at) das-netzwerkteam (dot) de
Created	12/26/2007 (6478 days ago)
Due
Updated	12/28/2007 (6476 days ago)
Assigned	12/26/2007 (6478 days ago)
Resolved	12/28/2007 (6476 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

12/28/2007 07:52:23 PM	Chuck Hagenbuch	State ⇒ Resolved

12/26/2007 07:55:13 PM	Michael Slusarz	Comment #13 State ⇒ Feedback	Reply to this comment
Found the issue. We were disabling the form before submitting, and disabled elements are not passed along in the request. Thus, submit first and disable and this should work again.

12/26/2007 06:57:43 PM	Matt Selsky	Comment #12	Reply to this comment
The enable has been in the code for a long time. I can confirm that "save" does nothing at the moment, besides reload the page. No JS errors in firebug.

12/26/2007 06:40:13 PM	Michael Slusarz	Comment #11 Assigned to Matt Selsky	Reply to this comment
I don't have access to ACL's either. But there is no reason why this shouldn't work (we use the exact same code elsewhere).

12/26/2007 06:11:32 PM	Chuck Hagenbuch	State ⇒ Assigned

12/26/2007 06:06:08 PM	Jan Schneider	Comment #10	Reply to this comment
I can confirm this, but didn't look into it any further.

12/26/2007 04:35:43 PM	Chuck Hagenbuch	Comment #9 State ⇒ Feedback	Reply to this comment
I don't have quick access to an install with ACLs enabled. Matt, can you reproduce any of this?

12/26/2007 04:24:15 PM	m (dot) gabriel (at) das-netzwerkteam (dot) de	Comment #8	Reply to this comment
It keeps the button from being clicked more than once. Maybe you can describe what does happen for you? Are there javascript errors? no there are no javascript errors on firefox's js console. my problems occur when adding a user to the acl list. changing ACLs of already added users work!!! again, i can not add a user with $("acl").disable() in the submit button's onClick tag. maybe i have been not as clear about that as i should have been... after having added a user and then pressing the submit button, the acl frame is reloaded (rather quickly), but no user has been added after the reload (no success notification appears at the top of the frame either). with the $("acl").disable() call removed from the onClick tag of the submit button a new user can be added to the acl list, the reload of the page is a bit slower than with the disable thing in the tag... users can be added: onclick="$('new_user').enable(); $('acl').submit();" user cannot be added: onclick="$('acl').disable(); $('new_user').enable(); $('acl').submit();"

12/26/2007 03:37:36 PM	Chuck Hagenbuch	Comment #7	Reply to this comment
It keeps the button from being clicked more than once. Maybe you can describe what does happen for you? Are there javascript errors?

12/26/2007 11:06:06 AM	m (dot) gabriel (at) das-netzwerkteam (dot) de	Comment #6	Reply to this comment
sorry, but the $('acl').disable() thing does not work for me. only if i remove $('acl').disable() or disableButtons() from the onClick tags the ACL changes of IMAP folders take effect... can you explain, what $('acl').disable() is supposed to do? it does not render the buttons useless, does it? i would not consider this resolved... mike

12/26/2007 06:38:47 AM	Michael Slusarz	Comment #5 State ⇒ Resolved	Reply to this comment
I think something like this is more appropriate. Michael S, can you confirm? Looks like I didn't catch this change in the template file. Patch applied, with a few tweaks.

12/26/2007 05:02:19 AM	Matt Selsky	Comment #4	Reply to this comment
Michael S. removed disableButtons() from imp/js/src/acl.js on November 27, 2007. But that function was still being called from acl.html

12/26/2007 04:15:55 AM	Chuck Hagenbuch	Comment #3 State ⇒ Feedback	Reply to this comment
What is the bug that these patches are trying to fix, though? They don't look to me like they're doing the same thing...

12/26/2007 01:47:32 AM	Matt Selsky	Comment #2 Assigned to Michael Slusarz State ⇒ Assigned New Attachment: acl.html.patch	Reply to this comment
I think something like this is more appropriate. Michael S, can you confirm?

12/26/2007 12:25:52 AM	m (dot) gabriel (at) das-netzwerkteam (dot) de	Comment #1 Priority ⇒ 1. Low State ⇒ Unconfirmed New Attachment: acl.patch Queue ⇒ IMP Type ⇒ Bug Summary ⇒ submit/back buttons disabled [->disableButton()] in acl.html template	Reply to this comment
submit/back buttons disabled [->disableButton()] in acl.html template "fix" is attached, bug also found in CVS.