6.0.0-beta1
9/5/25

[#602] messages displayed after ingo blacklist/whitelist are displayed as garbage
Summary messages displayed after ingo blacklist/whitelist are displayed as garbage
Queue Ingo
Queue Version RELENG_1
Type Bug
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester liamr (at) umich (dot) edu
Created 09/17/2004 (7658 days ago)
Due
Updated 09/20/2004 (7655 days ago)
Assigned 09/20/2004 (7655 days ago)
Resolved 09/20/2004 (7655 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
09/20/2004 09:51:24 PM Michael Slusarz Comment #9
State ⇒ Resolved
Reply to this comment
Sure - go ahead and send those directly to me (my email address is in 
the Owners line above).
09/20/2004 09:14:45 PM liamr (at) umich (dot) edu Comment #8 Reply to this comment
That seems to have done it.  Thanks so much!



I've also some template changes that make it look more like the 
current branch, and the Sieve whitelist handler for RELENG_1 if you 
guys want it.
09/20/2004 08:45:02 PM Michael Slusarz Comment #7 Reply to this comment
I'm beginning to see the problem (I think).  Namely, ingo uses 
Horde::compressOutput() to start page compression but this will only 
work if all other applications use that function to start page 
compression.  No other app does (it was only added to Horde in 2.2).   
Therefore, if an app enables compression without calling 
Horde::compressOutput(), then calls Ingo via an API, Ingo will 
compress the output again - this is resulting in the garbage that you 
are seeing.



So quick answer - there is really no way to reliably enable 
compression in ingo in RELENG_1 because there is no way to tell if the 
output in the buffer that has already been compressed, at least with 
the versions of PHP that Horde 2.x supports (namely, 
ob_list_handlers() is not available until PHP 4.3.0).  Thus it appears 
our only solution is to remove page compression from ingo.



So try what I just committed.  Hopefully this works.
09/20/2004 08:09:21 PM liamr (at) umich (dot) edu Comment #6 Reply to this comment
I had do add this to get around the non-object error message...



--- Horde.php.orig      2004-09-20 15:53:29.000000000 -0400

+++ Horde.php   2004-09-20 16:03:51.000000000 -0400

@@ -858,4 +858,7 @@

          }



+        include_once HORDE_BASE . '/lib/Browser.php';

+        $browser = new Browser();

+

          /* Netscape =< 4 is so buggy with compression that we just turn it

             completely off for those browsers. */





But that just puts me back to the original behavior (displaying the 
gzip output in the browser window when $conf['compress_pages'] is set 
to true).
09/20/2004 07:57:03 PM liamr (at) umich (dot) edu Comment #5 Reply to this comment
Ok.. the second patch makes Horde / IMP work again in general, but 
that branch of Ingo doesn't like it.  It doesn't return any output.   
This appears in the error log when using the patched Horde.php:



[Mon Sep 20 15:55:20 2004] [error] PHP Fatal error:  Call to a member 
function on a non-object in 
/usr/local/projects/webmail/html-ssl/horde-2.2.5/lib/Horde.php on line 
865


09/20/2004 07:21:21 PM Michael Slusarz Comment #4 Reply to this comment
09/20/2004 06:57:20 PM liamr (at) umich (dot) edu Comment #3 Reply to this comment
I put the patch into place and get this in the error log..



[Mon Sep 20 14:56:16 2004] [error] PHP Parse error:  parse error, 
unexpected T_STRING, expecting T_VARIABLE or '$' in 
/usr/local/projects/webmail/html-ssl/horde-2.2.5/lib/Horde.php on line 
863


09/20/2004 03:57:59 PM Michael Slusarz State ⇒ Assigned
Assigned to Michael Slusarz
 
09/17/2004 09:02:17 PM Jan Schneider Queue ⇒ Ingo
Version ⇒ RELENG_1
 
09/17/2004 08:06:41 PM liamr (at) umich (dot) edu Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ messages displayed after ingo blacklist/whitelist are displayed as garbage
Queue ⇒ IMP
State ⇒ Unconfirmed
Reply to this comment
If  $conf['compress_pages'] is set to "true", and you're using ingo to 
handle blacklist and whitelist for IMP 3.2.x, the pages displayed in 
the browser after following the "Blacklist" and "Whitelist" links are 
garbage and not rendered HTML.  (It's displaying the gzip compressed 
data instead of the page).



This is true for both index view (mailbox.php) and message view (message.php).



I realize that Ingo RELENG_1 isn't supported, but it would be nice if 
this worked.

Saved Queries