Summary | messages displayed after ingo blacklist/whitelist are displayed as garbage |
Queue | Ingo |
Queue Version | RELENG_1 |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | liamr (at) umich (dot) edu |
Created | 09/17/2004 (7658 days ago) |
Due | |
Updated | 09/20/2004 (7655 days ago) |
Assigned | 09/20/2004 (7655 days ago) |
Resolved | 09/20/2004 (7655 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Resolved
the Owners line above).
I've also some template changes that make it look more like the
current branch, and the Sieve whitelist handler for RELENG_1 if you
guys want it.
Horde::compressOutput() to start page compression but this will only
work if all other applications use that function to start page
compression. No other app does (it was only added to Horde in 2.2).
Therefore, if an app enables compression without calling
Horde::compressOutput(), then calls Ingo via an API, Ingo will
compress the output again - this is resulting in the garbage that you
are seeing.
So quick answer - there is really no way to reliably enable
compression in ingo in RELENG_1 because there is no way to tell if the
output in the buffer that has already been compressed, at least with
the versions of PHP that Horde 2.x supports (namely,
ob_list_handlers() is not available until PHP 4.3.0). Thus it appears
our only solution is to remove page compression from ingo.
So try what I just committed. Hopefully this works.
--- Horde.php.orig 2004-09-20 15:53:29.000000000 -0400
+++ Horde.php 2004-09-20 16:03:51.000000000 -0400
@@ -858,4 +858,7 @@
}
+ include_once HORDE_BASE . '/lib/Browser.php';
+ $browser = new Browser();
+
/* Netscape =< 4 is so buggy with compression that we just turn it
completely off for those browsers. */
But that just puts me back to the original behavior (displaying the
gzip output in the browser window when $conf['compress_pages'] is set
to true).
that branch of Ingo doesn't like it. It doesn't return any output.
This appears in the error log when using the patched Horde.php:
[Mon Sep 20 15:55:20 2004] [error] PHP Fatal error: Call to a member
function on a non-object in
/usr/local/projects/webmail/html-ssl/horde-2.2.5/lib/Horde.php on line
865
http://cvs.horde.org/diff.php/horde/lib/Attic/Horde.php?r1=1.118.2.53&r2=1.118.2.54&ty=u
[Mon Sep 20 14:56:16 2004] [error] PHP Parse error: parse error,
unexpected T_STRING, expecting T_VARIABLE or '$' in
/usr/local/projects/webmail/html-ssl/horde-2.2.5/lib/Horde.php on line
863
http://cvs.horde.org/diff.php/horde/lib/Attic/Horde.php?r1=1.118.2.52&r2=1.118.2.53&ty=u
Assigned to Michael Slusarz
Version ⇒ RELENG_1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ messages displayed after ingo blacklist/whitelist are displayed as garbage
Queue ⇒ IMP
State ⇒ Unconfirmed
handle blacklist and whitelist for IMP 3.2.x, the pages displayed in
the browser after following the "Blacklist" and "Whitelist" links are
garbage and not rendered HTML. (It's displaying the gzip compressed
data instead of the page).
This is true for both index view (mailbox.php) and message view (message.php).
I realize that Ingo RELENG_1 isn't supported, but it would be nice if
this worked.