6.0.0-beta1
10/16/25

[#601] RELENG_1 doesn't update whitelist rules in script
Summary RELENG_1 doesn't update whitelist rules in script
Queue Ingo
Queue Version RELENG_1
Type Bug
State Resolved
Priority 2. Medium
Owners jan (at) horde (dot) org
Requester liamr (at) umich (dot) edu
Created 09/17/2004 (7699 days ago)
Due
Updated 10/10/2004 (7676 days ago)
Assigned 09/17/2004 (7699 days ago)
Resolved 10/10/2004 (7676 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
10/10/2004 10:56:29 AM Jan Schneider Comment #4
State ⇒ Resolved
Reply to this comment
Committed by Michael.
09/17/2004 08:58:51 PM Jan Schneider Assigned to Jan Schneider
State ⇒ Assigned
 
09/17/2004 06:57:18 PM liamr (at) umich (dot) edu Comment #3
New Attachment: whitelist.diff Download
Reply to this comment
Looking at the code fore ingo/lib/Script/sieve.php, I found this block..



         /* Whitelist Script */

         $whitelist = $ingo['storage']->retrieve('whitelist');

         $whitelistBlocks = array();;

         if (!empty($whitelist)) {

             // Sieve whitelist TBP

         }



I'm guessing TBP means "to be programmed".



I looked at later versions of this file and have backported the 
whitelist function.  I *believe* it works.  The diff is attached.



Liam
09/17/2004 06:49:10 PM Jan Schneider Comment #2
State ⇒ Not A Bug
Reply to this comment
This version of Ingo is incomplete and not supported. Whitelists 
simply haven't been implemented for the Sieve driver.
09/17/2004 05:39:27 PM liamr (at) umich (dot) edu Comment #1
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ RELENG_1 doesn't update whitelist rules in script
Queue ⇒ Ingo
Reply to this comment
Ingo RELENG_1 doesn't seem to be creating whitelist rule entries for 
sieve scripts.  I see entries in my database for them...



| liamr    | ingo       | whitelist        | 
a:1:{i:0;s:15:"liamr@umich.edu";} |



...and ingo claims to update my rules and script when I add entries to 
the whitelist, but nothing in the script actually changes.



When I update my blacklist, my script actually contains...



3: # Blacklisted Addresses

4: if address :all :comparator "i;ascii-casemap" :is ["From", 
"Sender", "Resent-From"] "poop@poop.com"  {

5:     discard;

6:     stop;

7: }



There error log doesn't seem to contain anything useful.  I'm using it 
with Horde 2.2.5 and IMP 3.2.5, and other than this, it seems to work 
fine.

Saved Queries