Tickets :: [#5360] PHP 5 dependency

6.0.0-beta1

9/21/25

Summary	PHP 5 dependency
Queue	Ansel
Type	Bug
State	Resolved
Priority	2. Medium
Owners	mrubinsk (at) horde (dot) org
Requester	jan (at) horde (dot) org
Created	05/15/2007 (6704 days ago)
Due
Updated	06/15/2007 (6673 days ago)
Assigned	05/16/2007 (6703 days ago)
Resolved	06/15/2007 (6673 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

06/15/2007 08:24:05 PM	Chuck Hagenbuch	Comment #6 State ⇒ Resolved	Reply to this comment
Resolving since Ansel has its own TagCloud.php now.

05/16/2007 03:21:09 AM	Michael Rubinsky	State ⇒ Feedback

05/16/2007 03:15:35 AM	Michael Rubinsky	Comment #5	Reply to this comment
Ah. Ignore those last two posts. I see that is exactly what I just suggested regarding the CSS. Howeer, with the changes made to the Thomas version, the font-size -> item_count relationship is ignored...only the epoch value is used to determine both color and font-size. Not ideal for Ansel, IMO. So, again, if no one objects, I'll start with the original 1.1 revision of that file and then go from there...

05/15/2007 11:16:23 PM	Michael Rubinsky	Comment #4	Reply to this comment
Another thought about the tag cloud, is that the CSS for the anchors are output directly from the class. This could conceivably cause problems with some themes. What about putting the CSS for at least the <a> colors in screen.css?

05/15/2007 10:55:59 PM	Michael Rubinsky	Comment #3	Reply to this comment
I'd vote for copying the thomas TagCloud.php file in to Ansel for now For me, that version of TagCloud has been broken since it's orginal cvs import. Only cvs revision 1.1 has worked properly for me. With everything after 1.1, I get the tags output but with all the same font size. Unless anyone objects, I'll copy over the original revision and try to work from there...

05/15/2007 07:38:57 PM	Chuck Hagenbuch	Comment #2	Reply to this comment
I'd vote for copying the thomas TagCloud.php file in to Ansel for now and making it PHP 4-friendly; with Horde 4 hopefully we can turn the code into a single view helper that would provide this functionality.

05/15/2007 04:12:22 PM	Jan Schneider	Comment #1 Priority ⇒ 2. Medium Type ⇒ Bug Summary ⇒ PHP 5 dependency Queue ⇒ Ansel Assigned to Michael Rubinsky State ⇒ Assigned	Reply to this comment
HTML_TagCloud requires PHP 5 and Ansel requires HTML_TagCloud. Since this is the only PHP 5 dependancy, I suggest making the usage optional, or get our own PHP 4 implementation in Horde. Thomas (the module) has it's own implementation too, a common Horde version might make sense.