Ah right, we use them in form fields. Since casting form values to 
integers has the same effect as non-strict comparisons, I applied your 
patch, thanks.

Hello Jan,
I think the problem is related to the UI. If you change a recurrence, 
the internal PHP type for the form input is "string". Please consider 
this short code example:



<?php



define('HORDE_DATE_RECUR_NONE', 0);

$var = "0";



echo "hasRecurTypeOld: ".($var === HORDE_DATE_RECUR_NONE)."\n";

echo "hasRecurTypeNew: ".($var == HORDE_DATE_RECUR_NONE)."\n";

This doesn't make sense to me. We use constants for the recur type, so 
a strict comparison works fine here.

Giving to Jan since he's done all of the recent recurrence work.

Hello,



attached patch fixes a logic bug in hasRecurType(). Without the patch,

the recurs() function of an event always returns true.



Best regards,

Thomas Jarosch