Tickets :: [#5207] Make the deliverables billable/non-billable

6.0.0-beta1

7/25/25

Summary	Make the deliverables billable/non-billable
Queue	Hermes
Type	Enhancement
State	Resolved
Priority	1. Low
Owners
Requester	gnuwings (at) gmail (dot) com
Created	04/04/2007 (6687 days ago)
Due
Updated	10/18/2007 (6490 days ago)
Assigned
Resolved	10/18/2007 (6490 days ago)
Milestone
Patch	No

10/18/2007 08:59:10 AM	Jan Schneider	Comment #14 State ⇒ Resolved	Reply to this comment
Nevermind, I thought that configuration setting didn't exist yet.

10/18/2007 05:25:52 AM	vinay (dot) kumar (at) ejyothi (dot) com	Comment #13	Reply to this comment
Thanks For ensuring backward compatibility, we made changes based on the configuration variable $conf[time][choose_ifbillable],ie if this variable is enabled ,time slice is billable/non-billable ,otherwise jobtype can be billable/non-billable. I would like to know which changes are need to be done on conf.xml?

10/17/2007 05:53:18 PM	Jan Schneider	Comment #12	Reply to this comment
Tweaked (mostly whitespace), changed the default for job types to be billable, and committed. Your patch didn't include the changes to conf.xml though, can you please provide them?

10/17/2007 05:36:32 PM	Jan Schneider	Deleted Original Message

10/17/2007 05:36:23 PM	Jan Schneider	Deleted Original Message

10/17/2007 05:36:14 PM	Jan Schneider	Deleted Original Message

10/15/2007 01:10:17 PM	vinay (dot) kumar (at) ejyothi (dot) com	Comment #11 New Attachment: 2007-10-15_add_jobtype_billable.sql	Reply to this comment
Please find the the attached sql upgrade file 2007-10-15_add_jobtype_billable.sql

10/15/2007 01:08:39 PM	vinay (dot) kumar (at) ejyothi (dot) com	Comment #10 New Attachment: jobtype_patch-1.txt	Reply to this comment
With reference your previous message ,I have made changes in code and attached a new patch file for your reference. In case sql upgrade file,I have changed it to prefered sql syntax and it will be attached in next message.

10/12/2007 02:34:39 PM	vinay (dot) kumar (at) ejyothi (dot) com	Comment #9	Reply to this comment
Thanks I will post the patch after resolving sql compatibility issues and other stuffs related to coding.

10/12/2007 01:22:14 PM	Jan Schneider	Comment #8	Reply to this comment
Much better, thanks. There are still a few nits, sorry for being picky: - The sql upgrade script is for mysql. Please see docs/CODING_STANDARDS for preferred sql syntax, and other upgrade scripts for examples. - The default value of a "boolean" field type is already "false", no need to explicitly specify that. - Use "empty($var)" instead of "$var == false" especially for configuration values. - Add the end of the patch to Driver/sql.php you casted the rate to int and the billable flag to float, it should be the opposite.

10/12/2007 01:05:26 PM	vinay (dot) kumar (at) ejyothi (dot) com	Comment #7 New Attachment: 2007-10-12_add_jobtype_billable.sql	Reply to this comment
Please find the attachment 2007-10-12_add_jobtype_billable.sql file ( likely to put on scripts/upgrades )

10/12/2007 01:01:08 PM	vinay (dot) kumar (at) ejyothi (dot) com	Comment #6 New Attachment: jobtype_new_patch.txt	Reply to this comment
Sorry for my mistake and thanks for your valuable suggestions. Please find the attached patch file ,in this patch i tried to implement all of your suggestions. I have also attached (as a new comment) 2007-10-12_add_jobtype_billable.sql file it contains sql queries for upgrade.

10/12/2007 11:39:15 AM	Jan Schneider	Comment #5 State ⇒ Feedback	Reply to this comment
A few style comments, I didn't look at the actual code yet: - Please create unified diffs - Don't comment code out, if has to go, delete it - Don't keep debug code in the patches. - The applications' sql files only contain the sql statements necessary for the initial installation. If you have to change the sql schema, simply do so in the base sql file, and provide upgrade sql statements in separate sql scripts that go into scripts/upgrades/2007-01-01-some_script_name.sql

10/12/2007 09:30:32 AM	vinay (dot) kumar (at) ejyothi (dot) com	Comment #4 New Attachment: jobtype_patch.txt	Reply to this comment
With reference to the following post http://lists.horde.org/archives/dev/Week-of-Mon-20070917/022030.html I am submitting the first patch for adding billable/non-billable option in Jobtype

10/05/2007 02:26:59 AM	Chuck Hagenbuch	Comment #3	Reply to this comment
I think it'd be more manageable to make job types billable/not billable, since deliverables are rather arbitrary as they can be tasks, whatever. So it'd take a lot of metadata and tracking. Not that it'd be impossible if that's what people need.

10/04/2007 01:13:45 PM	manilal (dot) krishnapillai (at) ejyothi (dot) com	Comment #2	Reply to this comment
As I have mentioned in the mailing list, Our team is trying to enhance hermes. As a first step, we would like to fix some of the requests here. I would like to know which of the following is the best strategy : Is it good to make the deliverables billable/non-billable or make the job type billable/non-billable? Please provide your inputs.

04/10/2007 06:30:45 PM	Jan Schneider	State ⇒ Accepted

04/04/2007 05:49:19 AM	gnuwings (at) gmail (dot) com	Comment #1 Priority ⇒ 1. Low State ⇒ New Queue ⇒ Hermes Summary ⇒ Make the deliverables billable/non-billable Type ⇒ Enhancement	Reply to this comment
It would be nice if the deliverables or Job types can be marked as Billable and Non-billable. Currently employees are given the option to mark a specific time as billable/non-billable. This may not be ideal, because the lower level employees may mark some of the non-billable(Eg. Employee Leave, Vacation, etc..) hours as billable. This will also increase the security of the application.