Tickets :: [#4957] Problems with handling of default shares

6.0.0-beta1

9/20/25

Summary	Problems with handling of default shares
Queue	Horde Framework Packages
Queue Version	HEAD
Type	Bug
State	Resolved
Priority	1. Low
Owners
Requester	wrobel (at) pardus (dot) de
Created	01/31/2007 (6807 days ago)
Due
Updated	02/01/2007 (6806 days ago)
Assigned	01/31/2007 (6807 days ago)
Resolved	02/01/2007 (6806 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

02/01/2007 06:53:26 PM	Chuck Hagenbuch	Comment #6 State ⇒ Resolved	Reply to this comment
Committed, thanks!

02/01/2007 05:32:51 PM	Chuck Hagenbuch	Deleted Original Message

02/01/2007 05:32:43 PM	Chuck Hagenbuch	Deleted Original Message

02/01/2007 05:32:35 PM	Chuck Hagenbuch	Deleted Original Message

02/01/2007 05:32:29 PM	Chuck Hagenbuch	Deleted Original Message

02/01/2007 05:00:35 PM	wrobel (at) pardus (dot) de	Comment #5 New Attachment: framework-Share-Share-kolab.php_Default-share-handling_20070201.patch	Reply to this comment
Okay. Any reason to keep the existing patches then? No. I attached a new patch which applies only to framework/Share/Share/kolab.php then. I had to fix the way internal ID/share ID/share name/default attribute are handled so this is a larger patch.

01/31/2007 08:12:25 PM	Chuck Hagenbuch	Comment #4 State ⇒ Stalled	Reply to this comment
Okay. Any reason to keep the existing patches then?

01/31/2007 06:42:35 PM	wrobel (at) pardus (dot) de	Comment #3	Reply to this comment
This change completely breaks backwards compatibility. Why can't the Kolab driver support the current handling? Ah, sorry I have to admit that I did not consider backward compatibility at all. It will be possible to handle the issue without tampering with the nag, mnemo and kronolith side of things though this will require a less elegant solution on the side of the kolab driver. The reason why it does not work at the moment is that kolab uses a "default" attribute on the shares while the datatree driver uses the unique id of the object to indicate if it is a default share or not (ID==username if it is a default share, random number otherwise). I need to reconsider if I can reorganize the way the kolab driver uses the id so that it can convert the way horde uses the id into the necessary kolab attributes.

01/31/2007 05:57:55 PM	Chuck Hagenbuch	Comment #2 State ⇒ Feedback	Reply to this comment
This change completely breaks backwards compatibility. Why can't the Kolab driver support the current handling?

01/31/2007 01:53:11 PM		New Attachment: nag-lib-Nag.php_Default-share-handling_20070131.patch

01/31/2007 01:52:12 PM		New Attachment: mnemo-lib-Mnemo.php_Default-share-handling_20070131.patch

01/31/2007 01:51:44 PM		New Attachment: kronolith-lib-Kronolith.php_Default-share-handling_20070131.patch

01/31/2007 01:51:08 PM	wrobel (at) pardus (dot) de	Comment #1 Priority ⇒ 1. Low State ⇒ Unconfirmed New Attachment: framework-Share_Default-share-handling_20070131.patch Queue ⇒ Horde Framework Packages Summary ⇒ Problems with handling of default shares Type ⇒ Bug	Reply to this comment
Default shares are handled in a different way within Kolab as compared to the Datatree share model. To resolve these problems it would be good to move the default share handling into the Share driver rather than letting each groupware app handle the default share creation. The patch adds the necessary functions for both the datatree and the kolab driver. I tested both variants. The patch also fixes some problem with the handling of the "default" attribute within the current version of the kolab driver. The error handling for the kolab driver has also been improved since many of the IMAP errors that can be returned are rather incomprehensible. I'll also attach the necessary patches for nag, mnemo and kronolith so that they use the new default share handlers.