6.0.0-alpha12
6/12/25

[#4918] Group/ldap.php: getGroupMembership()
Summary Group/ldap.php: getGroupMembership()
Queue Horde Framework Packages
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners chuck (at) horde (dot) org
Requester patrick.abiven (at) apitech (dot) fr
Created 01/19/2007 (6719 days ago)
Due
Updated 11/24/2007 (6410 days ago)
Assigned 11/01/2007 (6433 days ago)
Resolved 11/24/2007 (6410 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
11/24/2007 09:48:55 PM Chuck Hagenbuch Comment #8
Assigned to Chuck Hagenbuch
State ⇒ Resolved
Reply to this comment
Resolving since there's been no negative feedback.
11/01/2007 03:12:24 AM Chuck Hagenbuch Comment #7
Taken from ben
Taken from Ben Klang
State ⇒ Feedback
Reply to this comment
I've added this along with several other improvements and bits of 
consistency in error checking. Please take a look at this diff:



http://cvs.horde.org/diff.php?r1=1.35&r2=1.36&f=framework%2FGroup%2FGroup%2Fldap.php



and test if possible. Apologies for the delay in getting to this. Thanks!
09/17/2007 02:48:23 PM Jan Schneider State ⇒ Assigned
 
09/14/2007 03:39:36 PM Jan Schneider Comment #6 Reply to this comment
Looks good.
09/12/2007 09:27:23 PM Ben Klang Comment #5 Reply to this comment
The function of the DN is to uniquely identify an object within an 
LDAP tree.  It can be any single attribute associated with an object; 
commonly it is a userid or email, but can be comprised as any value 
valid for the selected attribute.



I've been reading RFC2253 and from what I can tell, UTF-8 is right.

http://www.ietf.org/rfc/rfc2253.txt



Since I know very little about internationalization, can someone 
double check me before we commit this?
09/08/2007 09:07:13 AM Jan Schneider Comment #4 Reply to this comment
Two questions that I have:

- Is it save to assume that the data in LDAP is stored in UTF-8? 
Because that's what the patch does.

- What exactly makes up the DN and what are we assigning at this point 
in the quote? Background: do we need convert the charset of both, the 
array key and value?
09/08/2007 01:23:20 AM Ben Klang Comment #3
State ⇒ Feedback
Reply to this comment
I don't see any obvious problems with this fix, but it does raise one 
question in my mind:  Where else would we need to apply a similar fix? 
  Each time the DN is used?  Should there be a standard place or 
pattern to format the DN each time it's used?  Unfortunately I know 
very very little about character set conversion so I would appreciate 
any advice on this.
05/13/2007 04:27:36 AM Chuck Hagenbuch Comment #2 Reply to this comment
Pinging the Bens. :)
01/19/2007 05:07:20 PM Chuck Hagenbuch Assigned to ben
Assigned to Ben Klang
State ⇒ Assigned
 
01/19/2007 10:52:28 AM patrick (dot) abiven (at) apitech (dot) fr Comment #1
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Queue ⇒ Horde Framework Packages
Summary ⇒ Group/ldap.php: getGroupMembership()
Type ⇒ Bug
Reply to this comment
Hello

We are using ISO-8859-1 charset.

We are setting user permissions on shared calendars through ldap 
groups, but we notice that for some groups, the permissions are not set.



When a ldap group is located inside a ldap container whose name have 
french accent, the ldap.php getGroupMembership() function returns 
incorrect group name, and the permissions are not set.



Suggested workaround in Group/ldap.php line 709 (CVS version) :

- $groups[$result[$i]['dn']] = $result[$i][$this->_params['gid']][0];

+ $groups[ String::convertCharset($result[$i]['dn'], 'UTF-8', 
NLS::getCharset())] = 
String::convertCharset($result[$i][$this->_params['gid']][0], 'UTF-8', 
NLS::getCharset());



Regards

Patrick




Saved Queries