Tickets :: [#4690] Extended parameter support for the vfreebusy component of iCalendars

6.0.0-beta1

10/18/25

Summary	Extended parameter support for the vfreebusy component of iCalendars
Queue	Horde Framework Packages
Queue Version	HEAD
Type	Enhancement
State	Resolved
Priority	1. Low
Owners
Requester	wrobel (at) gentoo (dot) org
Created	11/23/2006 (6904 days ago)
Due
Updated	11/25/2006 (6902 days ago)
Assigned
Resolved	11/24/2006 (6903 days ago)
Milestone
Patch	No

11/25/2006 12:18:28 AM	Jan Schneider	Comment #11	Reply to this comment
Committed, thanks. You should always develop with error_reporting set to E_ALL by the way.

11/24/2006 11:57:51 PM	wrobel (at) gentoo (dot) org	Comment #10 New Attachment: test.patch	Reply to this comment
Ah, thanks for the hint. I did not see that I had the error reporting turned of so the notice created a problem. Patch for the test attached.

11/24/2006 11:39:48 PM	Jan Schneider	Comment #9	Reply to this comment
This error message is, what's causing the problems: PHP Notice: Undefined index: X-SUMMARY in /home/jan/headhorde/framework/iCalendar/tests/vfreebusy.php on line 134

11/24/2006 11:32:03 PM	wrobel (at) gentoo (dot) org	Comment #8	Reply to this comment
Did the vfreebusy.phpt test run before I updated the patch? Because I checked that the test runs through on my machine after I made the modifications. And even now, after the CVS update, the test runs through. I guess I made an incorrect assumption somewhere and it is somehow not independant of the machine it runs on (maybe timezone problems or something like that). Could you attach your test diff? Maybe that gives me an idea about what could be wrong.

11/24/2006 11:22:01 PM	Chuck Hagenbuch	Comment #7 State ⇒ Resolved	Reply to this comment
I've committed this since the patch looks okay, and I don't think it'll affect any existing functionality, but the vfreebusy.phpt test doesn't pass now - can you take a look and send an update? Thanks!

11/24/2006 09:55:48 PM	Chuck Hagenbuch	Deleted Original Message

11/24/2006 06:51:31 PM	wrobel (at) gentoo (dot) org	Comment #6 New Attachment: framework_iCalendar_iCalendar_vfreebusy.php-Kolab_iCalendar_fixes-20061124.patch	Reply to this comment
Ok, done. Thanks for the comments. There are still some long lines in there, hope that's ok.

11/24/2006 06:21:02 PM	Jan Schneider	Comment #5 State ⇒ Feedback	Reply to this comment
Please remove the outcommented debug lines from the patch, and use !empty() or !isset() instead of array_key_exists: http://www.horde.org/horde/docs/?f=CODING_STANDARDS.html#existence-checking

11/24/2006 06:06:25 PM	wrobel (at) gentoo (dot) org	Comment #4	Reply to this comment
Concerning the license it is fine. The author is probably Steffen Hansen but I guess you don't need the author for the patch, right? http://www.kolab.org/pipermail/kolab-devel/2006-November/006242.html

11/24/2006 02:44:18 AM	Chuck Hagenbuch	Comment #3 State ⇒ Stalled	Reply to this comment
No worries, I'm just going to stall the ticket until then to make sure.

11/23/2006 01:49:47 PM	wrobel (at) gentoo (dot) org	Comment #2 New Attachment: vfreebusy.phpt	Reply to this comment
The test suite for the modified class. I did actually forget to clarify the origins of the original patch. So please wait until I get the ok from the Kolab people. Sorry for that.

11/23/2006 01:48:05 PM	wrobel (at) gentoo (dot) org	Comment #1 Priority ⇒ 1. Low State ⇒ New New Attachment: framework_iCalendar_iCalendar_vfreebusy.php-Kolab_iCalendar_fixes-20061115.patch Queue ⇒ Horde Framework Packages Summary ⇒ Extended parameter support for the vfreebusy component of iCalendars Type ⇒ Enhancement	Reply to this comment
The iCal specification allows using additional Paramters on FREEBUSY properties: http://www.kanzaki.com/docs/ical/freebusy.html This is currently not supported by the iCalendar module of the Horde framework. The attached patch would add support for these extended parameters. I will also attach a test suite for the modified class. Some elements of the patch are also discussed here: http://www.kolab.org/pipermail/kolab-devel/2006-November/006236.html