6.0.0-alpha12
6/8/25

[#4474] spellcheck on Safari
Summary spellcheck on Safari
Queue DIMP
Type Bug
State Resolved
Priority 3. High
Owners Horde Developers (at)
Requester reitsma (at) denison (dot) edu
Created 09/29/2006 (6827 days ago)
Due
Updated 09/06/2017 (2832 days ago)
Assigned 09/30/2006 (6826 days ago)
Resolved 10/05/2006 (6821 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
09/06/2017 08:17:25 AM Git Commit Comment #8 Reply to this comment
Changes have been made in Git (master):

commit d98056759724f8d5e94a98038f61f7177e823c5f
Author: Paul M Jones <pmjones@ciaweb.net>
Date:   Mon May 30 13:37:47 2005 +0000

     fixed bug 4474 to silence calls to htmlentities and htmlspecialchars so
     that errors about charsets don't pop up, per counsel from Jan at Horde.


     git-svn-id: 
https://svn.php.net/repository/pear/packages/Text_Wiki/trunk@187320 
c90b9560-bf6c-de11-be94-00142212c4b1

  Text/Wiki/Render/Xhtml.php | 12 ++++++++----
  1 file changed, 8 insertions(+), 4 deletions(-)

http://github.com/horde/horde/commit/d98056759724f8d5e94a98038f61f7177e823c5f
10/07/2006 12:30:55 AM Chuck Hagenbuch Comment #7 Reply to this comment
Committed, thanks.
10/06/2006 08:11:26 PM reitsma (at) denison (dot) edu Comment #6 Reply to this comment
We found a case in which our patch failed: Internet Explorer in HTML 
mode. We again simplified the targetValue function in 
imp/js/SpellChecker.js from:



     targetValue: function(value)

     {

         if (value) {

             this.input.innerHTML = value;

             this.input.value = value;

         }

         return (typeof this.input.value == 'undefined') ? 
this.input.innerHTML : this.input.value;

     },



to:



     targetValue: function(value)

     {

         if (value) {

             this.input.value = value;

             return;

         }

         return (typeof this.input.value == 'undefined') ? 
this.input.innerHTML : this.input.value;

     },



to correctly handle Internet Explorer in both plain text and HTML mode 
(Windows only), Firefox in both plain text and HTML mode (Windows and 
OS X), and Safari plain text mode (OS X).
10/05/2006 06:43:34 PM Chuck Hagenbuch Comment #5
State ⇒ Resolved
Reply to this comment
Works for me. Committed, thanks.
10/05/2006 02:25:38 PM reitsma (at) denison (dot) edu Comment #4 Reply to this comment
We found that simplifying the targetValue function in

imp/js/SpellChecker.js from:



     targetValue: function(value)

     {

         // Ensure we have the correct input.

         this.input = $(this.target);



         if (value) {

             if (typeof this.input.value == 'undefined') {

                 this.input.innerHTML = value;

             } else {

                 this.input.value = value;

             }

         }

         return (typeof this.input.value == 'undefined') ? 
this.input.innerHTML : this.input.value;

     },



to:



     targetValue: function(value)

     {

         if (value) {

             this.input.innerHTML = value;

             this.input.value = value;

         }

         return (typeof this.input.value == 'undefined') ? 
this.input.innerHTML : this.input.value;

     },





solved the problem for Safari without breaking any of the other 
browsers we tested.
09/30/2006 08:58:55 PM Michael Slusarz Comment #3
Taken from Michael Slusarz
Reply to this comment
Unfortunately, I don't have access to a mac.
09/30/2006 01:06:46 AM Chuck Hagenbuch Comment #2
Assigned to Michael Slusarz
Assigned to Horde DevelopersHorde Developers
State ⇒ Assigned
Reply to this comment
Confirmed
09/29/2006 02:03:18 PM reitsma (at) denison (dot) edu Comment #1
Priority ⇒ 3. High
Type ⇒ Bug
Summary ⇒ spellcheck on Safari
Queue ⇒ DIMP
State ⇒ Unconfirmed
Reply to this comment
Once completed spell checking a message on the Safari browser, 
clicking on "Resume Editing" erases the entire message.

Saved Queries