I think it's safe to say that while not a comprehensive solution, the 
current vhost code works as intended. This will all be revisited for 
Horde 4.0.

- It was easier to implement.

- The vhost specific configuration file won't duplicate the complete 
configuration, e.g. if you want to change a setting for all domains, 
you need to login to each domain separately and change every single 
configuration, with your approach.

- You would have to lookup the the configuration files on the file 
system to determine whether you are going to edit the general or vhost 
configuration from the current setup screen.

That doesn't make as much sense to me. Why should the admin have to 
worry about maintaining manual diffs to the config files when the 
setup screens could easily do it for him/her? Also that makes the 
assumption that the admin wants any changes made to the default 
configuration reflected in the configuration for all domains. There is 
no reason to make that assumption.



Also, consider this scenerio: The admin maintains multiple domains on 
one Horde installation. He/she wants to test out the effects of a 
config change on one test domain only. Using your approach, there's no 
way to do that without manually editing config files. He/she has to 
manually parse the XML file and figure out what variable he/she needs 
to set and what data types it takes. I actually experienced that 
hassle myself which is why I created the bug report. With my approach, 
the admin just logs in under the test domain and makes the changes 
using the setup screens and only that domain is modified (if there is 
already a domain specific config file). To me that's much more more 
convenient.



What are the advantages of your approach?

This is not how it's supposed to work, you only edit the main 
configuration file through the admin interface and create config files 
for vhost manually that only contain the differences to the main 
configuration.

Stalling and giving to Jan for when he gets back, since he did the 
vhosting stuff.

Chuck wrote:
Hmmm... Saving a config file does not work for me on HEAD whether or 
not I'm using vhosted config files. It just sends me back to the Horde 
config setup screen when I click the save button for any Horde app. It 
does not actually save anything. It worked for me before the vhost 
update.
That's my point. If you're going to have virtual hosts then when you 
use the setup screen and you are accessing it via a domain that has an 
associated virtual host config file then that's the config file you 
should be editing. Not the default config file which has nothing to do 
with the VH domain you've logged in to!

I cannot reproduce any problems with config file generation right now, 
though I'm not using vhosted config files.



Also, unless there is functionality Jan added that I missed, vhosted 
config files are not handled by the setup screen at all.

Actually it looks like generating config files doesn't work at all 
under head right now. Clicking the "Generate ... Configuration" button 
just takes you back to the Horde configuration screen without writing 
anything.

If logged in to xyz.com as an admin and you edit the config files 
using http://xyz.com/horde/admin/setup/ Horde always reads and writes 
conf.php even if conf-xyz.com.php exists. Horde should only edit 
conf.php if conf-xyz.php does not exist.