Tickets :: [#4359] URL encoding bug with mailto-style links

6.0.0-beta1

7/22/25

Summary	URL encoding bug with mailto-style links
Queue	IMP
Queue Version	4.1.3
Type	Bug
State	Resolved
Priority	1. Low
Owners	Horde Developers (at)
Requester	ekendall (at) brandeis (dot) edu
Created	08/29/2006 (6902 days ago)
Due
Updated	11/26/2006 (6813 days ago)
Assigned	11/05/2006 (6834 days ago)
Resolved	11/26/2006 (6813 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

11/26/2006 04:37:10 AM	Chuck Hagenbuch	Comment #7 State ⇒ Resolved	Reply to this comment
I've tested this with both plaintext and html (mailto:) emails, and recent changes seem to have fixed this.

11/26/2006 04:36:36 AM	Chuck Hagenbuch	Deleted Original Message

11/05/2006 02:34:10 PM	Jan Schneider	Comment #6 State ⇒ Assigned Assigned to Horde Developers	Reply to this comment
Obviously not.

10/05/2006 12:38:06 PM	Jan Schneider	Comment #5	Reply to this comment
Are you going to update the patch?

09/05/2006 10:07:07 PM	Chuck Hagenbuch	Comment #4	Reply to this comment
No, IMP::composeLink is always called to generate compose links, not just from mailtos.

08/30/2006 11:50:29 AM	ekendall (at) brandeis (dot) edu	Comment #3	Reply to this comment
I thought that the place I put this /was/ when actually processing the args from a mailto URL. And you have to urldecode the subject line at some point, or else mailto links with spaces in the subject line won't work. I'd say that's worse that potentially mangling subjects that accidentally have what looks like url encoding in them, especially when many times the percent will itself be encoded. All the other mail programs I've tried (Thunderbird, OE, Mail.app) all parse "foo@bar.com?subject=baz%20quux" the way I expect, so I do think this is a bug. If you have a suggestion for a better place to fix it, I'd be happy to submit an updated patch.

08/30/2006 04:24:17 AM	Chuck Hagenbuch	Comment #2 State ⇒ Feedback	Reply to this comment
But if there were % characters in the subject parameter, that would improperly modify it. This should only be done when actually processing the args from a mailto url, not always.

08/29/2006 04:08:34 PM	ekendall (at) brandeis (dot) edu	Comment #1 Priority ⇒ 1. Low State ⇒ Unconfirmed New Attachment: urlencode.patch Queue ⇒ IMP Summary ⇒ URL encoding bug with mailto-style links Type ⇒ Bug	Reply to this comment
Email addresses of the style "foo@bar.com?subject=baz%20quux" are not properly stripped of URL encoding when being parsed into links. Running urldecode against all the arguments before urlencoding them seems to address the problem and shouldn't have any unwanted consequences.